Refactor ThreadPoolStats.Stats with Builder pattern#19317
Refactor ThreadPoolStats.Stats with Builder pattern#19317sandeshkr419 merged 1 commit intoopensearch-project:mainfrom
Conversation
github-actions
bot
added
enhancement
pado0
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
peternied,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19317 +/- ##
============================================
+ Coverage 73.07% 73.10% +0.02%
- Complexity 70741 70832 +91
============================================
Files 5732 5732
Lines 324140 324190 +50
Branches 46922 46922
============================================
+ Hits 236853 236985 +132
Misses 68117 68117
+ Partials 19170 19088 -82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pado0
force-pushed
the
builder-threadpool-stats
branch
from
b5ec9d0 to
8894339
Compare
|
❌ Gradle check result for 8894339: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 8894339: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sandeshkr419
left a comment
sandeshkr419
left a comment
There was a problem hiding this comment.
Can you please rebase with latest main, rest LGTM! Thanks!
pado0
force-pushed
the
builder-threadpool-stats
branch
from
8894339 to
2e01531
Compare
|
Looks like a lot of conflicts came in, rebase again? |
pado0
force-pushed
the
builder-threadpool-stats
branch
from
2e01531 to
fde2ddd
Compare
No worries! Thanks for keeping an eye on it. I’ve been checking things regularly and looking through other issues and code as well. Hope it gets merged soon :) |
pado0
force-pushed
the
builder-threadpool-stats
branch
from
fde2ddd to
bcb5719
Compare
|
❌ Gradle check result for bcb5719: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bcb5719: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bcb5719: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Jean Kim <bgshhd95@gmail.com>
pado0
force-pushed
the
builder-threadpool-stats
branch
from
bcb5719 to
32ef22c
Compare
…#19317) Signed-off-by: Jean Kim <bgshhd95@gmail.com>
2 participants
Description
This PR refactors the
ThreadPoolStats.Statsclass to use the Builder pattern instead of relying on multiple constructors.By adopting the Builder pattern, it becomes easier to evolve the stats API, add new metrics, and maintain backward compatibility without forcing disruptive constructor changes.
Based on the related issue:
There are multiple stats-related classes that need similar refactoring, and we are addressing them in priority order. This PR covers IndexingStats.Stats as part of that effort.
Related Issues
Partially resolves #19225
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.