-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Replace commons-lang:commons-lang with org.apache.commons:commons-lang3 #19229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace commons-lang:commons-lang with org.apache.commons:commons-lang3 #19229
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for 95b5c99: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 95b5c99: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <[email protected]>
plugins/discovery-azure-classic/src/main/java/org/apache/commons/lang/StringUtils.java
Show resolved
Hide resolved
|
❌ Gradle check result for bb27409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bb27409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bb27409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bb27409: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bb27409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bb27409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 6c3c7f7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19229 +/- ##
============================================
+ Coverage 72.84% 72.94% +0.09%
- Complexity 69857 69891 +34
============================================
Files 5674 5675 +1
Lines 320901 320911 +10
Branches 46394 46394
============================================
+ Hits 233756 234083 +327
+ Misses 68205 67956 -249
+ Partials 18940 18872 -68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
|
❕ Gradle check result for 5776ef4: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
@reta @rishabhmaurya @mch2 if you have some time today could you review this dependency update? |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-19229-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 765160067b3aa51ade52690a6f8c975c7a84ba21
# Push it to GitHub
git push --set-upstream origin backport/backport-19229-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19Then, create a pull request where the |
…g3 (opensearch-project#19229) * Replace commons-lang:commons-lang with org.apache.commons:commons-lang3 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create a shim around commons-lang3 StringUtils Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
My apologies @cwperks , just got to it but it is already merged, thanks @rishabhmaurya |
…g3 (#19229) (#19476) (cherry picked from commit 7651600) Signed-off-by: Craig Perkins <[email protected]>
…g3 (opensearch-project#19229) (opensearch-project#19476) (cherry picked from commit 7651600) Signed-off-by: Craig Perkins <[email protected]>
…g3 (opensearch-project#19229) * Replace commons-lang:commons-lang with org.apache.commons:commons-lang3 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create a shim around commons-lang3 StringUtils Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
…g3 (opensearch-project#19229) * Replace commons-lang:commons-lang with org.apache.commons:commons-lang3 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create a shim around commons-lang3 StringUtils Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
Description
Replace commons-lang:commons-lang with org.apache.commons:commons-lang3
Related Issues
commons-lang is not maintained and has moved to commons-lang3 per maven central: https://mvnrepository.com/artifact/commons-lang/commons-lang
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.