Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Sep 3, 2025

Description

Replace commons-lang:commons-lang with org.apache.commons:commons-lang3

Related Issues

commons-lang is not maintained and has moved to commons-lang3 per maven central: https://mvnrepository.com/artifact/commons-lang/commons-lang

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested review from a team and peternied as code owners September 3, 2025 16:59
Signed-off-by: Craig Perkins <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

❌ Gradle check result for 95b5c99: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

❌ Gradle check result for 95b5c99: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

❌ Gradle check result for bb27409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

❌ Gradle check result for bb27409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

❌ Gradle check result for bb27409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

❌ Gradle check result for bb27409: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

❌ Gradle check result for bb27409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

❌ Gradle check result for bb27409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

❌ Gradle check result for 6c3c7f7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

✅ Gradle check result for 6c3c7f7: SUCCESS

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.94%. Comparing base (af75e0b) to head (5776ef4).
⚠️ Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
...main/java/org/apache/commons/lang/StringUtils.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19229      +/-   ##
============================================
+ Coverage     72.84%   72.94%   +0.09%     
- Complexity    69857    69891      +34     
============================================
  Files          5674     5675       +1     
  Lines        320901   320911      +10     
  Branches      46394    46394              
============================================
+ Hits         233756   234083     +327     
+ Misses        68205    67956     -249     
+ Partials      18940    18872      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

❕ Gradle check result for 5776ef4: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@cwperks
Copy link
Member Author

cwperks commented Sep 30, 2025

@reta @rishabhmaurya @mch2 if you have some time today could you review this dependency update? commons-lang is being flagged on scans and needs to be removed as a dependency across the project in favor of commonslang3 which is actively maintained.

@cwperks cwperks merged commit 7651600 into opensearch-project:main Sep 30, 2025
36 of 37 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-19229-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 765160067b3aa51ade52690a6f8c975c7a84ba21
# Push it to GitHub
git push --set-upstream origin backport/backport-19229-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-19229-to-2.19.

asimmahmood1 pushed a commit to asimmahmood1/OpenSearch that referenced this pull request Sep 30, 2025
…g3 (opensearch-project#19229)

* Replace commons-lang:commons-lang with org.apache.commons:commons-lang3

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Create a shim around commons-lang3 StringUtils

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
@reta
Copy link
Contributor

reta commented Oct 2, 2025

@reta @rishabhmaurya @mch2 if you have some time today could you review this dependency update? commons-lang is being flagged on scans and needs to be removed as a dependency across the project in favor of commonslang3 which is actively maintained.

My apologies @cwperks , just got to it but it is already merged, thanks @rishabhmaurya

andrross pushed a commit that referenced this pull request Oct 14, 2025
…g3 (#19229) (#19476)

(cherry picked from commit 7651600)

Signed-off-by: Craig Perkins <[email protected]>
sokdak pushed a commit to sokdak/OpenSearch that referenced this pull request Oct 15, 2025
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…g3 (opensearch-project#19229)

* Replace commons-lang:commons-lang with org.apache.commons:commons-lang3

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Create a shim around commons-lang3 StringUtils

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
peterzhuamazon pushed a commit to peterzhuamazon/OpenSearch that referenced this pull request Nov 4, 2025
…g3 (opensearch-project#19229)

* Replace commons-lang:commons-lang with org.apache.commons:commons-lang3

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Create a shim around commons-lang3 StringUtils

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants