-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Upgrade multiple deps including bc-fips jars and transport-reactor-netty4 #19222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tty4 Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for 6f251c6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for c699e1c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cwperks !
Signed-off-by: Craig Perkins <[email protected]>
|
@reta I pushed a new commit because there are tests failing due to thread leak detection: https://build.ci.opensearch.org/job/gradle-check/63211/ The leaked threads are: |
|
❌ Gradle check result for 2c9d269: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@cwperks by setting |
This reverts commit 2c9d269. Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for a854320: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This didn't seem to work. Did I configure it correctly? The ThreadFilter worked, but I needed to apply it to some more tests. Lmk which method would be preferable here. |
test/framework/src/main/java/org/opensearch/test/OpenSearchTestCase.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 697fb4c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1ac363d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for dc011de: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@cwperks my apologies, I derailed you here, the change that actually disables BC cleanup turned out to be very recent and comes with the next release (2.1.2), sorry about that, I was very surprised as well to discover it. The filter seems to be the only way for 2.1 |
Thank you for checking @reta! I'll add the filter back in and create a GH issue to track its removal once 2.1.2 is released. |
This reverts commit dc011de. Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for a7faba9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for a7faba9: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for a7faba9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19222 +/- ##
============================================
- Coverage 72.87% 72.82% -0.05%
+ Complexity 69698 69625 -73
============================================
Files 5656 5656
Lines 319999 319999
Branches 46335 46335
============================================
- Hits 233207 233052 -155
- Misses 67946 68083 +137
- Partials 18846 18864 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@reta would you mind re-approving? |
…tty4 (opensearch-project#19222) * Upgrade multiple deps including bc-fips jars and transport-reactor-netty4 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> * Revert "Create BouncyCastleThreadFilter" This reverts commit 2c9d269. Signed-off-by: Craig Perkins <[email protected]> * Set org.bouncycastle.native.cleanup_delay to 0 for testing Signed-off-by: Craig Perkins <[email protected]> * Revert "Revert "Create BouncyCastleThreadFilter"" This reverts commit dc011de. Signed-off-by: Craig Perkins <[email protected]> * Re-add BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
…tty4 (opensearch-project#19222) * Upgrade multiple deps including bc-fips jars and transport-reactor-netty4 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> * Revert "Create BouncyCastleThreadFilter" This reverts commit 2c9d269. Signed-off-by: Craig Perkins <[email protected]> * Set org.bouncycastle.native.cleanup_delay to 0 for testing Signed-off-by: Craig Perkins <[email protected]> * Revert "Revert "Create BouncyCastleThreadFilter"" This reverts commit dc011de. Signed-off-by: Craig Perkins <[email protected]> * Re-add BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
…tty4 (opensearch-project#19222) * Upgrade multiple deps including bc-fips jars and transport-reactor-netty4 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> * Revert "Create BouncyCastleThreadFilter" This reverts commit 2c9d269. Signed-off-by: Craig Perkins <[email protected]> * Set org.bouncycastle.native.cleanup_delay to 0 for testing Signed-off-by: Craig Perkins <[email protected]> * Revert "Revert "Create BouncyCastleThreadFilter"" This reverts commit dc011de. Signed-off-by: Craig Perkins <[email protected]> * Re-add BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
…tty4 (opensearch-project#19222) * Upgrade multiple deps including bc-fips jars and transport-reactor-netty4 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> * Revert "Create BouncyCastleThreadFilter" This reverts commit 2c9d269. Signed-off-by: Craig Perkins <[email protected]> * Set org.bouncycastle.native.cleanup_delay to 0 for testing Signed-off-by: Craig Perkins <[email protected]> * Revert "Revert "Create BouncyCastleThreadFilter"" This reverts commit dc011de. Signed-off-by: Craig Perkins <[email protected]> * Re-add BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
…tty4 (opensearch-project#19222) * Upgrade multiple deps including bc-fips jars and transport-reactor-netty4 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> * Revert "Create BouncyCastleThreadFilter" This reverts commit 2c9d269. Signed-off-by: Craig Perkins <[email protected]> * Set org.bouncycastle.native.cleanup_delay to 0 for testing Signed-off-by: Craig Perkins <[email protected]> * Revert "Revert "Create BouncyCastleThreadFilter"" This reverts commit dc011de. Signed-off-by: Craig Perkins <[email protected]> * Re-add BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
…tty4 (opensearch-project#19222) * Upgrade multiple deps including bc-fips jars and transport-reactor-netty4 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> * Revert "Create BouncyCastleThreadFilter" This reverts commit 2c9d269. Signed-off-by: Craig Perkins <[email protected]> * Set org.bouncycastle.native.cleanup_delay to 0 for testing Signed-off-by: Craig Perkins <[email protected]> * Revert "Revert "Create BouncyCastleThreadFilter"" This reverts commit dc011de. Signed-off-by: Craig Perkins <[email protected]> * Re-add BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
…tty4 (opensearch-project#19222) * Upgrade multiple deps including bc-fips jars and transport-reactor-netty4 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Create BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> * Revert "Create BouncyCastleThreadFilter" This reverts commit 2c9d269. Signed-off-by: Craig Perkins <[email protected]> * Set org.bouncycastle.native.cleanup_delay to 0 for testing Signed-off-by: Craig Perkins <[email protected]> * Revert "Revert "Create BouncyCastleThreadFilter"" This reverts commit dc011de. Signed-off-by: Craig Perkins <[email protected]> * Re-add BouncyCastleThreadFilter Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
Description
This PR contains the following updates:
io.projectreactor.netty:reactor_nettyfrom1.2.5to1.2.9org.bouncycastle:bouncycastle_jcefrom2.0.0to2.1.1org.bouncycastle:bouncycastle_tlsfrom2.0.20to2.1.20org.bouncycastle:bouncycastle_pkixfrom2.0.8to2.1.9org.bouncycastle:bouncycastle_pgfrom2.0.11to2.1.11org.bouncycastle:bouncycastle_utilfrom2.0.3to2.1.4Related Issues
Resolves CVE-2025-22227 and CVE-2025-8916
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.