[Pull-based Ingestion] Fix ingestion pause state initialization on replica promotion #19212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
>test-failure
varunbharadwaj
force-pushed
the
vb/17693
branch
from
73456b3 to
b837a39
Compare
Contributor
|
❌ Gradle check result for b837a39: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
varunbharadwaj
force-pushed
the
vb/17693
branch
from
b837a39 to
1898a82
Compare
Contributor
|
❌ Gradle check result for 1898a82: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
varunbharadwaj
force-pushed
the
vb/17693
branch
from
1898a82 to
228b3d9
Compare
Contributor
|
❌ Gradle check result for 228b3d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <[email protected]>
varunbharadwaj
force-pushed
the
vb/17693
branch
from
228b3d9 to
7b285a5
Compare
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19212 +/- ##
============================================
+ Coverage 72.87% 72.89% +0.02%
- Complexity 69698 69708 +10
============================================
Files 5656 5656
Lines 319999 320000 +1
Branches 46335 46336 +1
============================================
+ Hits 233207 233278 +71
+ Misses 67946 67889 -57
+ Partials 18846 18833 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
…arch-project#19212) Signed-off-by: Varun Bharadwaj <[email protected]>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…arch-project#19212) Signed-off-by: Varun Bharadwaj <[email protected]>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…arch-project#19212) Signed-off-by: Varun Bharadwaj <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…arch-project#19212) Signed-off-by: Varun Bharadwaj <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
asimmahmood1
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 23, 2025
…arch-project#19212) Signed-off-by: Varun Bharadwaj <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…arch-project#19212) Signed-off-by: Varun Bharadwaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ingestion state was persisted in the cluster state on calling Pause API but the poller was not considering this on replica promotion. Initialize the poller state correctly by considering the initial state passed by the engine. This should avoid the pollers resuming ingestion on replica promotion, and also fix flaky tests.
Related Issues
Resolves #17693
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.