Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand SearchPlugin javadocs. #1909

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Expand SearchPlugin javadocs. #1909

merged 1 commit into from
Jan 14, 2022

Conversation

mattweber
Copy link
Contributor

Description

Add and clarify some search plugin point documentation.

Issues Resolved

#1905

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mattweber
Expand SearchPlugin javadocs.
1908136 
Add and clarify some search plugin point documentation.

Signed-off-by: Matt Weber <[email protected]>
@mattweber mattweber requested a review from a team as a code owner January 14, 2022 18:18
@mattweber
Copy link
Contributor Author

/CC @nknize

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

nknize
nknize approved these changes Jan 14, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thx @mattweber

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 1908136
Log 1926

Reports 1926

@nknize nknize merged commit 524448f into opensearch-project:main Jan 14, 2022
@nknize
Copy link
Collaborator

nknize commented Jan 14, 2022

Let's backport this as well.

@nknize nknize added documentation Improvements or additions to documentation Indexing & Search pending backport Identifies an issue or PR that still needs to be backported v1.3.0 labels Jan 14, 2022
mattweber added a commit to mattweber/OpenSearch that referenced this pull request Jan 17, 2022
@mattweber
Expand SearchPlugin javadocs. (opensearch-project#1909)
f06d61a 
Add and clarify some search plugin point documentation.

Signed-off-by: Matt Weber <[email protected]>
@mattweber mattweber mentioned this pull request Jan 17, 2022
Merged
5 tasks
@mattweber
Copy link
Contributor Author

@nknize backport PR #1923

nknize pushed a commit that referenced this pull request Jan 18, 2022
@mattweber
Expand SearchPlugin javadocs. (#1909) (#1923)
60cb4e2 
Add and clarify some search plugin point documentation.

Signed-off-by: Matt Weber <[email protected]>
@andrross andrross mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Indexing & Search pending backport Identifies an issue or PR that still needs to be backported v1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattweber @opensearch-ci-bot @nknize @dblock