Fix broken yml test for combined_fields #18971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test breaks with a repeatable seed because we randomly set shard count above 1 which will impact scoring. Fixing it by setting shard count to 1 instead of using dfs query then fetch. Signed-off-by: Marc Handalian <[email protected]>
github-actions
bot
added
bug
|
Thanks @mch2 seen a failure in past https://build.ci.opensearch.org/job/gradle-check/61541/testReport/. |
prudhvigodithi
approved these changes
Aug 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18971 +/- ##
============================================
+ Coverage 72.89% 72.96% +0.07%
- Complexity 69318 69348 +30
============================================
Files 5642 5642
Lines 318636 318636
Branches 46107 46107
============================================
+ Hits 232254 232495 +241
+ Misses 67540 67317 -223
+ Partials 18842 18824 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
prudhvigodithi
merged commit 292a2c5
into
opensearch-project:main
36 of 37 checks passed
RajatGupta02
pushed a commit
to RajatGupta02/OpenSearch
that referenced
this pull request
Aug 18, 2025
This test breaks with a repeatable seed because we randomly set shard count above 1 which will impact scoring. Fixing it by setting shard count to 1 instead of using dfs query then fetch. Signed-off-by: Marc Handalian <[email protected]>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
This test breaks with a repeatable seed because we randomly set shard count above 1 which will impact scoring. Fixing it by setting shard count to 1 instead of using dfs query then fetch. Signed-off-by: Marc Handalian <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
This test breaks with a repeatable seed because we randomly set shard count above 1 which will impact scoring. Fixing it by setting shard count to 1 instead of using dfs query then fetch. Signed-off-by: Marc Handalian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test breaks with a repeatable seed because we randomly set shard count above 1 which changes doc count per segment and therefore scoring. Fixing it by setting shard count to 1. We could also resolve this by using dfs searchType, but seems the precedent in our yml tests is to fix the shard count.
Related Issues
Resolves #18881
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.