refactor: Convert if-else chains to switch expressions (#17874)

[BeomSeogKim]

Description

[Describe what this change achieves]
As proposed in issue #17874, this PR refactors several if-else chains that use instanceof checks into more readable and modern Java 17 pattern matching switch statements. This improves code clarity and maintainability.

Affected files:
  - Numbers.java: toLongExact, toBigIntegerExact methods
  - ExceptionsHelper.java: exception handling methods
  - NestedHelper.java: query matching methods
  - ValueSource.java: value wrapping logic
  - SearchSortValuesAndFormats.java: sort value formatting
  - BulkItemResponse.java: response type serialization
  - DocWriteRequest.java: request serialization methods

Related Issues

Resolves #17874

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[Copilot]

Pull Request Overview

This PR refactors if-else chains that use instanceof checks into modern Java 17 pattern matching switch expressions, improving code readability and maintainability.

• Converts traditional instanceof checks with explicit casting to pattern matching syntax
• Replaces long if-else chains with more concise and readable switch expressions
• Modernizes exception handling patterns using switch expressions

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
SearchSortValuesAndFormats.java	Converts sort value type checking from if-else chain to switch expression
ValueSource.java	Refactors value wrapping logic to use pattern matching switch
NestedHelper.java	Modernizes query type checking methods with switch expressions
BulkItemResponse.java	Simplifies response type serialization using switch
DocWriteRequest.java	Converts document request serialization to switch pattern
SocketChannelContext.java	Updates exception handling to use switch expression
NioSelectorGroup.java	Modernizes exception type checking with pattern matching
LoggerMessageFormat.java	Converts array type checking to switch expression
BytesReference.java	Simplifies stream type checking with switch
ExceptionsHelper.java	Refactors exception handling methods to use switch expressions
Numbers.java	Converts number type checking methods to pattern matching switch

[github-actions]

❌ Gradle check result for 59c35f7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[BeomSeogKim]

Hello maintainers,

I am reopening this pull request. I had briefly closed it because I was surprised by the automated comment from the bot and wasn't sure what the next step was. 😅

I've reopened it now to proceed. If there's a specific action required from me based on the bot's message, could you please guide me?

Thank you for your understanding.

[cwperks]

I've never seen that before. Did Copilot just perform a review unprompted?

[github-actions]

❌ Gradle check result for f384f62: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 55675d6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[github-actions]

✅ Gradle check result for 1fe001d: SUCCESS

[codecov]

Codecov Report

❌ Patch coverage is 75.38462% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.89%. Comparing base (3e747cb) to head (50931d6).
⚠️ Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
...in/java/org/opensearch/action/DocWriteRequest.java	57.14%	10 Missing and 2 partials ⚠️
...earch/core/common/logging/LoggerMessageFormat.java	0.00%	10 Missing ⚠️
...java/org/opensearch/index/search/NestedHelper.java	85.71%	1 Missing and 6 partials ⚠️
.../opensearch/search/SearchSortValuesAndFormats.java	58.33%	4 Missing and 1 partial ⚠️
.../java/org/opensearch/nio/SocketChannelContext.java	0.00%	4 Missing ⚠️
...c/main/java/org/opensearch/ingest/ValueSource.java	84.00%	2 Missing and 2 partials ⚠️
...main/java/org/opensearch/nio/NioSelectorGroup.java	0.00%	3 Missing ⚠️
...a/org/opensearch/action/bulk/BulkItemResponse.java	40.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18965      +/-   ##
============================================
+ Coverage     72.79%   72.89%   +0.10%     
- Complexity    69605    69630      +25     
============================================
  Files          5658     5658              
  Lines        320079   320061      -18     
  Branches      46345    46290      -55     
============================================
+ Hits         232996   233307     +311     
+ Misses        68230    67866     -364     
- Partials      18853    18888      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[BeomSeogKim]

@andrross could you check one more time? I refactor the code causing test failure.

[sandeshkr419]

The changes look neat with a small nit-pick.

Thanks for working on these changes.

[github-actions]

✅ Gradle check result for 50931d6: SUCCESS