[BUG FIX] Using an excessively large reindex slice can lead to a JVM OutOfMemoryError on coordinator

[sunqijun1]

Description

Currently, OpenSearch's restrictions and checks on search slice parameters are inappropriate. In the code, search slices size check in each shard execution. If there is a problem with the verification on the shard, an exception will be thrown on the shard. This is a relatively slow process.

Therefore, we need to change this approach. we need to move the validation of slice parameters to the coordinator node to detect issues earlier.

Related Issues

Resolves #18963

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for f42bf6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 955ccc2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ab6e2e4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ab6e2e4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for ab6e2e4: SUCCESS

[codecov]

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.94%. Comparing base (7c1052f) to head (f4ce31a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...dex/reindex/BulkByScrollParallelizationHelper.java	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18964      +/-   ##
============================================
+ Coverage     72.82%   72.94%   +0.11%     
- Complexity    69677    69772      +95     
============================================
  Files          5658     5658              
  Lines        320099   320108       +9     
  Branches      46348    46350       +2     
============================================
+ Hits         233110   233491     +381     
+ Misses        68088    67749     -339     
+ Partials      18901    18868      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

❌ Gradle check result for 2c7897f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 2c7897f: SUCCESS

[kkewwei]

@ankitkala I apologize for taking up your time, but I’m genuinely unsure who else to ask for a review. As I noticed you’ve modified the reindex code in the past, I’d be extremely grateful if you could review it at your convenience. Thank you so much for your help.

[github-actions]

❕ Gradle check result for 4bfd6ec: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

❌ Gradle check result for bbf2503: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for f4ce31a: SUCCESS

[kkewwei]

LGTM