Skip to content

Conversation

@atris
Copy link
Contributor

@atris atris commented Aug 5, 2025

When update operations with retry_on_conflict encounter version conflicts, each retry attempt was triggering the original refresh policy (IMMEDIATE, WAIT_UNTIL), causing unnecessary refresh operations that degrade performance.

This change suppresses the refresh policy to NONE for retry attempts while preserving the original policy for the initial attempt. The refresh will still happen once when the update eventually succeeds or fails permanently.

Fixes #15261

@atris atris requested a review from a team as a code owner August 5, 2025 08:31
@github-actions github-actions bot added bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing labels Aug 5, 2025
@atris atris force-pushed the update_refr_fix branch from 015b334 to f7c7292 Compare August 5, 2025 08:38
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

✅ Gradle check result for f7c7292: SUCCESS

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.76%. Comparing base (cff74ff) to head (50b95bb).
⚠️ Report is 51 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18917      +/-   ##
============================================
- Coverage     72.78%   72.76%   -0.02%     
+ Complexity    68681    68665      -16     
============================================
  Files          5582     5582              
  Lines        315495   315502       +7     
  Branches      45784    45785       +1     
============================================
- Hits         229625   229579      -46     
- Misses        67223    67280      +57     
+ Partials      18647    18643       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atris
Copy link
Contributor Author

atris commented Aug 5, 2025

@shwetathareja

…ts),

  TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>
@atris atris force-pushed the update_refr_fix branch from f7c7292 to 50b95bb Compare August 5, 2025 17:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for 50b95bb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@atris
Copy link
Contributor Author

atris commented Aug 6, 2025

Flaky tests #15813

@atris atris closed this Aug 6, 2025
@atris atris reopened this Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

✅ Gradle check result for 50b95bb: SUCCESS

Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, thanks @atris !

@mch2 mch2 merged commit 4b114c0 into opensearch-project:main Aug 7, 2025
58 of 60 checks passed
RajatGupta02 pushed a commit to RajatGupta02/OpenSearch that referenced this pull request Aug 18, 2025
…ts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>
RajatGupta02 pushed a commit to RajatGupta02/OpenSearch that referenced this pull request Aug 18, 2025
…ts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>
RajatGupta02 pushed a commit to RajatGupta02/OpenSearch that referenced this pull request Aug 26, 2025
…ts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>
cwperks added a commit that referenced this pull request Aug 27, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes #15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC #18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (#18936)


---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (#19031)



---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
atris added a commit to atris/OpenSearch that referenced this pull request Aug 28, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (opensearch-project#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (opensearch-project#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC opensearch-project#18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (opensearch-project#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (opensearch-project#18936)


---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (opensearch-project#19031)



---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
pranikum pushed a commit to pranikum/OpenSearch that referenced this pull request Sep 4, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (opensearch-project#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (opensearch-project#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC opensearch-project#18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (opensearch-project#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (opensearch-project#18936)


---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (opensearch-project#19031)



---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Sep 5, 2025
…ts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Sep 5, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (opensearch-project#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (opensearch-project#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC opensearch-project#18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (opensearch-project#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (opensearch-project#18936)


---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (opensearch-project#19031)



---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (opensearch-project#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (opensearch-project#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC opensearch-project#18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (opensearch-project#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (opensearch-project#18936)


---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (opensearch-project#19031)



---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (opensearch-project#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (opensearch-project#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC opensearch-project#18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (opensearch-project#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (opensearch-project#18936)

---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (opensearch-project#19031)

---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (opensearch-project#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (opensearch-project#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC opensearch-project#18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (opensearch-project#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (opensearch-project#18936)

---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (opensearch-project#19031)

---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
asimmahmood1 pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 23, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (opensearch-project#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (opensearch-project#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC opensearch-project#18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (opensearch-project#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (opensearch-project#18936)


---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (opensearch-project#19031)



---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
…ts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
* Add overload for channelFactory

Signed-off-by: Rajat Gupta <[email protected]>

* Fix tests

Signed-off-by: Rajat Gupta <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Fix conflicts

Signed-off-by: Rajat Gupta <[email protected]>

* When update operations fail during preparation (e.g., version conflicts), (opensearch-project#18917)

TransportShardBulkAction still triggers refresh even though no actual
  writes occurred. This fix checks if locationToSync is null (indicating
  no writes) and prevents refresh in such cases.

  Fixes opensearch-project#15261

Signed-off-by: Atri Sharma <[email protected]>

* Remove all entries from changelog to be released in 3.2 (opensearch-project#18989)

Signed-off-by: Andrew Ross <[email protected]>

* Add temporal routing processors for time-based document routing (opensearch-project#18966)

Implements TemporalRoutingProcessor for ingest pipelines and
TemporalRoutingSearchProcessor for search pipelines based on RFC opensearch-project#18920.

 Features:
 - Route documents to shards based on timestamp fields
 - Support hour, day, week, and month granularities
 - Optional hash bucketing for better distribution
 - Automatic search routing to relevant time ranges
 - ISO week format support

The processors enable efficient time-based data organization for
log and metrics workloads by co-locating documents from the same
time period on the same shards.

---------

Signed-off-by: Atri Sharma <[email protected]>

* Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl (opensearch-project#18998)

* Add CompletableFuture variables to methods in the Client Interface and default to ActionListener impl

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Fix typo in CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Switch to CompletionStage

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>

* Expand fetch phase profiling to support inner hits and top hits aggregation phases (opensearch-project#18936)


---------

Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>

* IllegalArgumentException when scroll ID has a node no longer part of the Cluster (opensearch-project#19031)



---------

Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>

* Add Changelog entry

Signed-off-by: Rajat Gupta <[email protected]>

* Add secondary constructor

Signed-off-by: Rajat Gupta <[email protected]>

* Modify changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Update changelog

Signed-off-by: Rajat Gupta <[email protected]>

* Add another constructor to fix breaking change check

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Atri Sharma <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Signed-off-by: Anurag Rai <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
Co-authored-by: Atri Sharma <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Andre van de Ven <[email protected]>
Co-authored-by: Anurag Rai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] TransportUpdateAction trigger refresh for every failed retry attempt also during conflict

2 participants