Skip to content

Conversation

@willyborankin
Copy link
Contributor

Description

Resolve an issue with the SOCKS5 proxy authentication settings (username and password) for the Azure repository.

Previously, SOCKS5 username and password were set using the JDK Authenticator, but the Azure client provides this configuration through the ProxyOptions class

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@willyborankin willyborankin force-pushed the fix-socks5-azure branch 2 times, most recently from db59e91 to 3581388 Compare August 4, 2025 14:48
@willyborankin willyborankin marked this pull request as ready for review August 4, 2025 14:49
@willyborankin willyborankin requested a review from a team as a code owner August 4, 2025 14:49
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

❌ Gradle check result for 3581388: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

✅ Gradle check result for 3581388: SUCCESS

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.79%. Comparing base (a9b6d7a) to head (3581388).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...search/repositories/azure/AzureStorageService.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18904      +/-   ##
============================================
- Coverage     72.93%   72.79%   -0.14%     
+ Complexity    68855    68773      -82     
============================================
  Files          5590     5590              
  Lines        315887   315887              
  Branches      45839    45839              
============================================
- Hits         230382   229952     -430     
- Misses        66832    67284     +452     
+ Partials      18673    18651      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants