Skip to content

Conversation

@karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Jul 31, 2025

Description

  1. Upgrade to protobufs 0.6.0 where the query name field was renamed from name to underscore_name
  2. Clean up some deprecated TermQueryProtoUtils code

Related Issues

#16787

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for e4091f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for e4091f4: SUCCESS

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.85%. Comparing base (d52d404) to head (e4091f4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18880      +/-   ##
============================================
+ Coverage     72.74%   72.85%   +0.11%     
- Complexity    68675    68730      +55     
============================================
  Files          5582     5582              
  Lines        315495   315452      -43     
  Branches      45784    45776       -8     
============================================
+ Hits         229502   229828     +326     
+ Misses        67396    67015     -381     
- Partials      18597    18609      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karenyrx karenyrx marked this pull request as ready for review July 31, 2025 18:35
@karenyrx karenyrx requested a review from a team as a code owner July 31, 2025 18:35
@karenyrx
Copy link
Contributor Author

cc @andrross @finnegancarroll @msfroh would you mind helping take a look when you have time? thanks!

@andrross andrross merged commit 9b22c9b into opensearch-project:main Jul 31, 2025
62 of 64 checks passed
sunqijun1 pushed a commit to sunqijun1/OpenSearch that referenced this pull request Aug 4, 2025
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants