-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Star-Tree] Search level stats for nodes, indices and shards #18707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Gradle check result for ad439e8: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 7431dfd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 26fd3d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
d966f1f to
cb1a9de
Compare
server/src/main/java/org/opensearch/index/search/stats/SearchStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/cat/RestIndicesAction.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for cb1a9de: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Shouldn't we enable a new metric group for STAR TREE: https://docs.opensearch.org/docs/latest/api-reference/nodes-apis/nodes-stats/ |
@getsaurabh02 I'd argue otherwise. The reason to place it inside @expani @bharath-techie Looping you both in the thread, please review/evaluate the placement of metrics if this needs any change than the current state. |
c139f7d to
e674fad
Compare
|
❌ Gradle check result for e674fad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 78480c6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18707 +/- ##
============================================
- Coverage 72.79% 72.74% -0.05%
+ Complexity 68525 68447 -78
============================================
Files 5574 5566 -8
Lines 314807 314660 -147
Branches 45675 45649 -26
============================================
- Hits 229178 228915 -263
- Misses 67046 67133 +87
- Partials 18583 18612 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sandeshkr419 PR looks good but lets add end to end test which utilizes star tree and assert the stats. Now that we don't have feature flag protection , we should be able to do this. |
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
server/src/main/java/org/opensearch/index/search/stats/SearchStats.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/search/stats/StarTreeSearchStatsIT.java
Show resolved
Hide resolved
|
❌ Gradle check result for f75a836: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandesh Kumar <[email protected]>
…rch-project#18707) * startree node,indices,shards stats Signed-off-by: Sandesh Kumar <[email protected]> * changing to builder pattern Signed-off-by: Sandesh Kumar <[email protected]> * add query current, fix version Signed-off-by: Sandesh Kumar <[email protected]> * fix version Signed-off-by: Sandesh Kumar <[email protected]> * add integ test Signed-off-by: Sandesh Kumar <[email protected]> * typo Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]>
…rch-project#18707) * startree node,indices,shards stats Signed-off-by: Sandesh Kumar <[email protected]> * changing to builder pattern Signed-off-by: Sandesh Kumar <[email protected]> * add query current, fix version Signed-off-by: Sandesh Kumar <[email protected]> * fix version Signed-off-by: Sandesh Kumar <[email protected]> * add integ test Signed-off-by: Sandesh Kumar <[email protected]> * typo Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]>
…rch-project#18707) * startree node,indices,shards stats Signed-off-by: Sandesh Kumar <[email protected]> * changing to builder pattern Signed-off-by: Sandesh Kumar <[email protected]> * add query current, fix version Signed-off-by: Sandesh Kumar <[email protected]> * fix version Signed-off-by: Sandesh Kumar <[email protected]> * add integ test Signed-off-by: Sandesh Kumar <[email protected]> * typo Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]>
…rch-project#18707) * startree node,indices,shards stats Signed-off-by: Sandesh Kumar <[email protected]> * changing to builder pattern Signed-off-by: Sandesh Kumar <[email protected]> * add query current, fix version Signed-off-by: Sandesh Kumar <[email protected]> * fix version Signed-off-by: Sandesh Kumar <[email protected]> * add integ test Signed-off-by: Sandesh Kumar <[email protected]> * typo Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]>
Description
Adding metric data for star-tree search queries.
Documentation: opensearch-project/documentation-website#10667
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.