[fixes #16599] Field-level ignore_malformed should override index-level setting

[mishail]

Description

There are 9 types of fields that support setting of ignore_malformed property, see the table below.

The current logic checks for the index level FieldMapper.IGNORE_MALFORMED_SETTING in catch section in parse(ParseContext context) in the FieldMapper class. The current implementation has no visibility into field level settings.

The proposed changes adding an ability for FieldMapper to get access field-level setting via ignoreMalformed() method.

Type	Controlling class
ip	IpFieldMapper
ip_range	RangeFieldMapper
geo_point	AbstractGeometryFieldMapper
geo_shape	AbstractGeometryFieldMapper
xy_point	AbstractGeometryFieldMapper
xy_shape	AbstractGeometryFieldMapper
numerics	NumberFieldMapper, ScaledFloatFieldMapper
derived	DerivedFieldMapper
date	DateFieldMapper

Related Issues

Resolves #16599

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for be93286: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.77%. Comparing base (548e467) to head (21d0cd5).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
.../java/org/opensearch/index/mapper/FieldMapper.java	55.55%	2 Missing and 2 partials ⚠️
...rg/opensearch/index/mapper/DerivedFieldMapper.java	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18706      +/-   ##
============================================
- Coverage     72.90%   72.77%   -0.14%     
+ Complexity    68587    68512      -75     
============================================
  Files          5566     5566              
  Lines        314701   314712      +11     
  Branches      45653    45653              
============================================
- Hits         229434   229032     -402     
- Misses        66655    67057     +402     
- Partials      18612    18623      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

❌ Gradle check result for 5f37584: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[mishail]

Do we have a test anywhere that verifies the field level setting overrides an index-level setting? Perhaps a new case can be added here:

https://github.com/opensearch-project/OpenSearch/blob/3e9a420533f67157ea521fe23212a3a07754c2bf/rest-api-spec/src/main/resources/rest-api-spec/test/search/200_ignore_malformed.yml

Now I've added a new test there. Let me know if that's sufficient

[github-actions]

❌ Gradle check result for 76990b8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for f44fbf4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 4336b3a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

✅ Gradle check result for 5a095f2: SUCCESS

[mishail]

@andrross this is ready for review. Thanks for the feedback!

[github-actions]

✅ Gradle check result for 21d0cd5: SUCCESS