Fix flaky test in IngestServiceTests #18623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stsWithMatchingChildSlots Signed-off-by: guojialiang <[email protected]>
Member
|
@guojialiang92 have we run this test for multiple iterations and see that this does not fail even after 1K (more the merrier) iterations? |
ashking94
changed the title
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18623 +/- ##
============================================
+ Coverage 72.66% 72.68% +0.01%
- Complexity 68231 68254 +23
============================================
Files 5555 5556 +1
Lines 313857 313887 +30
Branches 45522 45529 +7
============================================
+ Hits 228073 228136 +63
+ Misses 67207 67164 -43
- Partials 18577 18587 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
Signed-off-by: guojialiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky test
IngestServiceTests#testExecuteBulkRequestInBatchWithExceptionAndDropInCallback_requestsWithMatchingChildSlots.Related gradle test.
Related Issues
Resolves #[18622]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.