[BUG FIX] Fix the visit of sub queries for HasParentQuery and HasChildQuery #18621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luyuncheng <[email protected]>
luyuncheng
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Signed-off-by: luyuncheng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18621 +/- ##
============================================
+ Coverage 72.75% 72.78% +0.03%
- Complexity 68402 68403 +1
============================================
Files 5563 5563
Lines 314164 314170 +6
Branches 45554 45554
============================================
+ Hits 228556 228674 +118
+ Misses 67087 66942 -145
- Partials 18521 18554 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: luyuncheng <[email protected]>
bugmakerrrrrr
approved these changes
Jun 26, 2025
modules/parent-join/src/main/java/org/opensearch/join/query/HasChildQueryBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: luyuncheng <[email protected]>
|
❌ Gradle check result for 4cef3d5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: luyuncheng <[email protected]>
|
❌ Gradle check result for f0bb922: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for f0bb922: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
bugmakerrrrrr
merged commit 6154ffe
into
opensearch-project:main
32 of 34 checks passed
vishdivs
pushed a commit
to vishdivs/OpenSearch
that referenced
this pull request
Jul 14, 2025
…dQuery (opensearch-project#18621) * ADD Parent-Join visit method. Signed-off-by: luyuncheng <[email protected]> * ADD Parent-Join visit method. Signed-off-by: luyuncheng <[email protected]> * ADD Parent-Join visit method. Signed-off-by: luyuncheng <[email protected]> * ADD Parent-Join visit method. Signed-off-by: luyuncheng <[email protected]> --------- Signed-off-by: luyuncheng <[email protected]>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
…dQuery (opensearch-project#18621) * ADD Parent-Join visit method. Signed-off-by: luyuncheng <[email protected]> * ADD Parent-Join visit method. Signed-off-by: luyuncheng <[email protected]> * ADD Parent-Join visit method. Signed-off-by: luyuncheng <[email protected]> * ADD Parent-Join visit method. Signed-off-by: luyuncheng <[email protected]> --------- Signed-off-by: luyuncheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #13837 AND #14739 i see it fixed many scenarios queries, but we still need Join Query Builder to visit query builders. especially for neural search can visit embedding or other field
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.