Extend Profiler to allow for non-timing info #18618
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuenfeldttj
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
❌ Gradle check result for 4ec61fa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
neuenfeldttj
force-pushed
the
profile-metrics
branch
from
4ec61fa to
01deee6
Compare
Contributor
Author
|
@reta Let me know if there's anything that should change! |
Contributor
|
❌ Gradle check result for affba92: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
neuenfeldttj
force-pushed
the
profile-metrics
branch
from
affba92 to
4ec61fa
Compare
Contributor
|
❌ Gradle check result for 4ec61fa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@neuenfeldttj Can we take a look at the failing builds/checks? |
neuenfeldttj
force-pushed
the
profile-metrics
branch
from
4ec61fa to
166b7f3
Compare
neuenfeldttj
force-pushed
the
profile-metrics
branch
from
166b7f3 to
8e66782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a smaller PR that helps solve #18460.
Timernow extends a new class calledProfileMetric. The new code works how the current profiler code works but allows a breakdown to output all information (timers and non-timers). This will be useful for plugins once plugin profiling is supported. Concurrency is also achieved by determining the timers/non-timers and aggregating accordingly. Also, enums were eliminated from the generics so that the profiler could be more extensible and support this.Related Issues
Resolves part of #18486
Resolves part of #18460
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.