Skip to content

Conversation

@liuyonghengheng
Copy link
Contributor

Description

The logs rolling triggered AccessControlException, and the log files access permission are not rw-r-----. More and more users get this error, although it is not a fatal issue, it is a issue that we will encounter when out-of-the-box,so i think we should fix it.

Related Issues

Resolves #18594 #9609

Test

The test Result is expected behavior
image

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@liuyonghengheng liuyonghengheng requested a review from a team as a code owner June 24, 2025 10:28
@github-actions github-actions bot added _No response_ bug Something isn't working labels Jun 24, 2025
@github-actions
Copy link
Contributor

❕ Gradle check result for cf30aec: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.96%. Comparing base (f03d743) to head (7ee545c).
Report is 8 commits behind head on 2.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.19   #18597      +/-   ##
============================================
+ Coverage     71.83%   71.96%   +0.12%     
- Complexity    65910    66000      +90     
============================================
  Files          5341     5341              
  Lines        307194   307194              
  Branches      44835    44835              
============================================
+ Hits         220664   221061     +397     
+ Misses        68065    67720     -345     
+ Partials      18465    18413      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liuyonghengheng liuyonghengheng force-pushed the 2.19_dev branch 5 times, most recently from 57c6caf to 4c89362 Compare June 25, 2025 01:53
@github-actions
Copy link
Contributor

❕ Gradle check result for 4c89362: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. @cwperks what do you think?

@github-actions github-actions bot added Other security Anything security related labels Jul 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

❌ Gradle check result for 7ee545c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@liuyonghengheng
Copy link
Contributor Author

Hi @andrross @cwperks , I have tried to fix the last check error (add a new line about change log in CHANGELOG.md),the new check triggered a new error in gradle check ,but the error IT(org.opensearch.remotestore.RemoteStorePinnedTimestampsGarbageCollectionIT.testLiveIndexWithPinnedTimestamps) can pass in my local laptop (ubuntu 24). Please help take a look ,what's wrong whith this PR flow,and what shuld I do

@github-actions
Copy link
Contributor

❕ Gradle check result for 7ee545c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@andrross andrross merged commit 2975205 into opensearch-project:2.19 Jul 18, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working _No response_ Other security Anything security related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants