-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix the bug of Access denied error when rolling log files #18597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❕ Gradle check result for cf30aec: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.19 #18597 +/- ##
============================================
+ Coverage 71.83% 71.96% +0.12%
- Complexity 65910 66000 +90
============================================
Files 5341 5341
Lines 307194 307194
Branches 44835 44835
============================================
+ Hits 220664 221061 +397
+ Misses 68065 67720 -345
+ Partials 18465 18413 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
57c6caf to
4c89362
Compare
|
❕ Gradle check result for 4c89362: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
andrross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. @cwperks what do you think?
Signed-off-by: Yongheng Liu <[email protected]>
|
❌ Gradle check result for 7ee545c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Hi @andrross @cwperks , I have tried to fix the last check error (add a new line about change log in CHANGELOG.md),the new check triggered a new error in gradle check ,but the error IT(org.opensearch.remotestore.RemoteStorePinnedTimestampsGarbageCollectionIT.testLiveIndexWithPinnedTimestamps) can pass in my local laptop (ubuntu 24). Please help take a look ,what's wrong whith this PR flow,and what shuld I do |
|
❕ Gradle check result for 7ee545c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
The logs rolling triggered AccessControlException, and the log files access permission are not
rw-r-----. More and more users get this error, although it is not a fatal issue, it is a issue that we will encounter when out-of-the-box,so i think we should fix it.Related Issues
Resolves #18594 #9609
Test
The test Result is expected behavior

Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.