Solving wildcard sorting issue for doc_values #18568
Conversation
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 164a85e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 1825559: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rest-api-spec/src/main/resources/rest-api-spec/test/search/270_wildcard_fieldtype_queries.yml
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for f16b39f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 1741b80: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 90f73e2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for ffda262: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 723ab8f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for b54c85e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
Co-authored-by: HUSTERGS <[email protected]> Signed-off-by: Anthony Leong <[email protected]>
ajleong623
requested review from
Bukhtawar,
CEHENKLE,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis and
gbbafna
as code owners
|
❌ Gradle check result for c1f59b6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 91ca440: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❕ Gradle check result for f033417: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for e55207c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Anthony Leong <[email protected]>
|
@msfroh Since I made some changes from the last time you approved, I wanted to confirm if the new changes are still approved. What was happening with serializing the sort field was that the proper source was not being returned. Therefore, I returned the original comparator source and disabled pruning earlier when creating |
--------- Signed-off-by: Anthony Leong <[email protected]> Co-authored-by: HUSTERGS <[email protected]>
--------- Signed-off-by: Anthony Leong <[email protected]> Co-authored-by: HUSTERGS <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
--------- Signed-off-by: Anthony Leong <[email protected]> Co-authored-by: HUSTERGS <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
--------- Signed-off-by: Anthony Leong <[email protected]> Co-authored-by: HUSTERGS <[email protected]>
--------- Signed-off-by: Anthony Leong <[email protected]> Co-authored-by: HUSTERGS <[email protected]>
--------- Signed-off-by: Anthony Leong <[email protected]> Co-authored-by: HUSTERGS <[email protected]>
4 participants
Description
Solves the wildcard sorting issue.
Issues Resolved
#18461
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.