Added approximation support for range queries with now in date field #18511

sawansri · 2025-06-12T22:59:50Z

Description

Rewrites DateRangeIncludingNowQuery logic in handleNow to utilize optimizations made to Point Range Queries.

Related Issues

Resolves #18503

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2025-06-12T23:11:23Z

❌ Gradle check result for a10494d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-06-12T23:41:42Z

❌ Gradle check result for d3a0085: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-06-12T23:59:24Z

❌ Gradle check result for 93d2077: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/index/mapper/DateFieldMapper.java

server/src/test/java/org/opensearch/index/query/RangeQueryBuilderTests.java

github-actions · 2025-06-14T00:05:03Z

❌ Gradle check result for 4d47c42: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-06-16T17:43:13Z

❌ Gradle check result for 0b81313: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

modules/percolator/src/main/java/org/opensearch/percolator/QueryAnalyzer.java

server/src/test/java/org/opensearch/search/approximate/ApproximatePointRangeQueryTests.java

prudhvigodithi · 2025-06-16T17:56:34Z

Adding @kkewwei as well for the PR review.

modules/percolator/src/main/java/org/opensearch/percolator/QueryAnalyzer.java

github-actions · 2025-06-16T19:47:35Z

❌ Gradle check result for 5aa1e77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sawansri · 2025-06-16T19:51:58Z

❌ Gradle check result for 5aa1e77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test: #18310

github-actions · 2025-06-16T20:51:07Z

❌ Gradle check result for 1cd4d4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sawansri · 2025-06-16T20:54:36Z

❌ Gradle check result for 1cd4d4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test: #15840

github-actions · 2025-06-16T22:08:57Z

❌ Gradle check result for 3f49bd6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sawansri · 2025-06-16T22:10:03Z

❌ Gradle check result for 3f49bd6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test: #14509

server/src/test/java/org/opensearch/search/approximate/ApproximatePointRangeQueryTests.java

github-actions · 2025-06-16T23:29:14Z

❌ Gradle check result for 3f49bd6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-06-17T18:32:17Z

❌ Gradle check result for ccaebc3: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-06-17T22:17:11Z

✅ Gradle check result for 0a0fa31: SUCCESS

Signed-off-by: Sawan Srivastava <[email protected]>

…ersions Signed-off-by: Sawan Srivastava <[email protected]>

Signed-off-by: Sawan Srivastava <[email protected]>

github-actions · 2025-07-28T23:06:44Z

❌ Gradle check result for b1d070a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sawansri · 2025-07-28T23:34:49Z

❌ Gradle check result for b1d070a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test: #17937

Signed-off-by: Sawan Srivastava <[email protected]>

github-actions · 2025-07-29T00:04:26Z

❌ Gradle check result for 76b2863: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-07-29T02:33:32Z

✅ Gradle check result for 76b2863: SUCCESS

prudhvigodithi · 2025-07-29T05:25:31Z

@kkewwei @sandeshkr419 are we good this PR?

kkewwei

LGTM

…pensearch-project#18511) * Added approximation support for range queries with now in date field Signed-off-by: Sawan Srivastava <[email protected]> * Updated tests to fit new query hierarchy Signed-off-by: Sawan Srivastava <[email protected]> * refactored approximation logic for DateRangeIncludingNowQuery Signed-off-by: Sawan Srivastava <[email protected]> * added validation test for DateRangeIncludingNowQuery approximation Signed-off-by: Sawan Srivastava <[email protected]> * fixed percolation query analyzer logic to check for DateRangeIncludingNowQuery Signed-off-by: Sawan Srivastava <[email protected]> * updated DateFieldTypeTests to reflect new DateRangeIncludingNow query structure Signed-off-by: Sawan Srivastava <[email protected]> * refactored date range query to use overloaded function and cleaned up percolation subquery visitor logic Signed-off-by: Sawan Srivastava <[email protected]> * cleaned up testApproximateVsExactQuery function signature Signed-off-by: Sawan Srivastava <[email protected]> * Rerun gradle check Signed-off-by: Sawan Srivastava <[email protected]> * Removed redundancy in DateRangeIncludingNow approximation logic Signed-off-by: Sawan Srivastava <[email protected]> * Refactored DateRangeIncludingNowTests for conciseness Signed-off-by: Sawan Srivastava <[email protected]> * applied spotless Signed-off-by: Sawan Srivastava <[email protected]> * Removed unused handleNow method Signed-off-by: Sawan Srivastava <[email protected]> * refactored approximation wrapping logic Signed-off-by: Sawan Srivastava <[email protected]> * applied spotless Signed-off-by: Sawan Srivastava <[email protected]> * Refactored tests to use DateFieldType Signed-off-by: Sawan Srivastava <[email protected]> * applied spotless Signed-off-by: Sawan Srivastava <[email protected]> * Refactored DateRangeIncludingNow tests to reflect new parameterized versions Signed-off-by: Sawan Srivastava <[email protected]> * update CHANGELOG.md Signed-off-by: Sawan Srivastava <[email protected]> * rerun gradle check Signed-off-by: Sawan Srivastava <[email protected]> --------- Signed-off-by: Sawan Srivastava <[email protected]> Signed-off-by: sunqijun.jun <[email protected]>

…pensearch-project#18511) * Added approximation support for range queries with now in date field Signed-off-by: Sawan Srivastava <[email protected]> * Updated tests to fit new query hierarchy Signed-off-by: Sawan Srivastava <[email protected]> * refactored approximation logic for DateRangeIncludingNowQuery Signed-off-by: Sawan Srivastava <[email protected]> * added validation test for DateRangeIncludingNowQuery approximation Signed-off-by: Sawan Srivastava <[email protected]> * fixed percolation query analyzer logic to check for DateRangeIncludingNowQuery Signed-off-by: Sawan Srivastava <[email protected]> * updated DateFieldTypeTests to reflect new DateRangeIncludingNow query structure Signed-off-by: Sawan Srivastava <[email protected]> * refactored date range query to use overloaded function and cleaned up percolation subquery visitor logic Signed-off-by: Sawan Srivastava <[email protected]> * cleaned up testApproximateVsExactQuery function signature Signed-off-by: Sawan Srivastava <[email protected]> * Rerun gradle check Signed-off-by: Sawan Srivastava <[email protected]> * Removed redundancy in DateRangeIncludingNow approximation logic Signed-off-by: Sawan Srivastava <[email protected]> * Refactored DateRangeIncludingNowTests for conciseness Signed-off-by: Sawan Srivastava <[email protected]> * applied spotless Signed-off-by: Sawan Srivastava <[email protected]> * Removed unused handleNow method Signed-off-by: Sawan Srivastava <[email protected]> * refactored approximation wrapping logic Signed-off-by: Sawan Srivastava <[email protected]> * applied spotless Signed-off-by: Sawan Srivastava <[email protected]> * Refactored tests to use DateFieldType Signed-off-by: Sawan Srivastava <[email protected]> * applied spotless Signed-off-by: Sawan Srivastava <[email protected]> * Refactored DateRangeIncludingNow tests to reflect new parameterized versions Signed-off-by: Sawan Srivastava <[email protected]> * update CHANGELOG.md Signed-off-by: Sawan Srivastava <[email protected]> * rerun gradle check Signed-off-by: Sawan Srivastava <[email protected]> --------- Signed-off-by: Sawan Srivastava <[email protected]>

github-actions bot added bug Something isn't working Search:Performance labels Jun 12, 2025

sawansri force-pushed the sawansri branch from a10494d to e4542e5 Compare June 12, 2025 23:24

sawansri changed the title ~~Added approximation support for range queries with @now in date field~~ Added approximation support for range queries with now in date field Jun 12, 2025

sawansri force-pushed the sawansri branch from e4542e5 to d3a0085 Compare June 12, 2025 23:25

sawansri force-pushed the sawansri branch from b539cba to 93d2077 Compare June 12, 2025 23:46

prudhvigodithi reviewed Jun 13, 2025

View reviewed changes

sawansri force-pushed the sawansri branch from 396e3de to 4d47c42 Compare June 13, 2025 23:45

prudhvigodithi reviewed Jun 16, 2025

View reviewed changes

modules/percolator/src/main/java/org/opensearch/percolator/QueryAnalyzer.java Outdated Show resolved Hide resolved

prudhvigodithi reviewed Jun 16, 2025

View reviewed changes

server/src/test/java/org/opensearch/search/approximate/ApproximatePointRangeQueryTests.java Outdated Show resolved Hide resolved

prudhvigodithi reviewed Jun 16, 2025

View reviewed changes

modules/percolator/src/main/java/org/opensearch/percolator/QueryAnalyzer.java Outdated Show resolved Hide resolved

sawansri force-pushed the sawansri branch from 0d6c864 to 5aa1e77 Compare June 16, 2025 18:35

opensearch-ci-bot mentioned this pull request Jun 16, 2025

[AUTOCUT] Gradle Check Flaky Test Report for ReactorNetty4StreamingStressIT #15840

Closed

prudhvigodithi reviewed Jun 16, 2025

View reviewed changes

server/src/test/java/org/opensearch/search/approximate/ApproximatePointRangeQueryTests.java Outdated Show resolved Hide resolved

opensearch-ci-bot mentioned this pull request Jun 17, 2025

[AUTOCUT] Gradle Check Flaky Test Report for RecoveryWhileUnderLoadIT #14509

Open

sawansri added 11 commits July 28, 2025 22:35

Rerun gradle check

b59993b

Signed-off-by: Sawan Srivastava <[email protected]>

Removed redundancy in DateRangeIncludingNow approximation logic

56b5173

Signed-off-by: Sawan Srivastava <[email protected]>

Refactored DateRangeIncludingNowTests for conciseness

4204f37

Signed-off-by: Sawan Srivastava <[email protected]>

applied spotless

b2160e5

Signed-off-by: Sawan Srivastava <[email protected]>

Removed unused handleNow method

0bd7a62

Signed-off-by: Sawan Srivastava <[email protected]>

refactored approximation wrapping logic

307aa27

Signed-off-by: Sawan Srivastava <[email protected]>

applied spotless

3184ce8

Signed-off-by: Sawan Srivastava <[email protected]>

Refactored tests to use DateFieldType

534937f

Signed-off-by: Sawan Srivastava <[email protected]>

applied spotless

f5e343f

Signed-off-by: Sawan Srivastava <[email protected]>

Refactored DateRangeIncludingNow tests to reflect new parameterized v…

0f51035

…ersions Signed-off-by: Sawan Srivastava <[email protected]>

update CHANGELOG.md

b1d070a

Signed-off-by: Sawan Srivastava <[email protected]>

sawansri force-pushed the sawansri branch from 8111a46 to b1d070a Compare July 28, 2025 22:41

rerun gradle check

76b2863

Signed-off-by: Sawan Srivastava <[email protected]>

prudhvigodithi approved these changes Jul 29, 2025

View reviewed changes

github-project-automation bot moved this from In-Review to In Progress in Performance Roadmap Jul 29, 2025

prudhvigodithi added the v3.2.0 label Jul 29, 2025

kkewwei approved these changes Jul 29, 2025

View reviewed changes

prudhvigodithi merged commit b0417f3 into opensearch-project:main Jul 29, 2025
36 of 65 checks passed

github-project-automation bot moved this from In Progress to Done in Performance Roadmap Jul 29, 2025

opensearch-ci-bot mentioned this pull request Jul 29, 2025

[AUTOCUT] Gradle Check Flaky Test Report for FullRollingRestartIT #18490

Closed

opensearch-ci-bot mentioned this pull request May 12, 2025

[AUTOCUT] Gradle Check Flaky Test Report for RethrottleTests #17937

Open

BrewTestBot mentioned this pull request Aug 20, 2025

opensearch 3.2.0 Homebrew/homebrew-core#234146

Merged

Added approximation support for range queries with now in date field #18511

Added approximation support for range queries with now in date field #18511

Uh oh!

Conversation

sawansri commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

prudhvigodithi commented Jun 16, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

sawansri commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

sawansri commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

sawansri commented Jun 16, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

sawansri commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

prudhvigodithi commented Jul 29, 2025

Uh oh!

kkewwei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sawansri commented Jun 12, 2025 •

edited

Loading