-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Bug fix] Rule based Auto tagging update rule api #18488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jainankitk
merged 1 commit into
opensearch-project:main
from
ruai0511:update-rule-bugfix
Jun 11, 2025
Merged
[Bug fix] Rule based Auto tagging update rule api #18488
jainankitk
merged 1 commit into
opensearch-project:main
from
ruai0511:update-rule-bugfix
Jun 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruirui Zhang <[email protected]>
28d1368 to
3f2f49e
Compare
Contributor
|
❌ Gradle check result for 3f2f49e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Seems like a flaky test: Retrying the gradle check |
jainankitk
approved these changes
Jun 11, 2025
Contributor
jainankitk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kaushalmahi12
approved these changes
Jun 11, 2025
abhita
pushed a commit
to abhita/OpenSearch
that referenced
this pull request
Jun 17, 2025
Signed-off-by: Ruirui Zhang <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Ruirui Zhang <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Ruirui Zhang <[email protected]>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Ruirui Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for https://github.com/opensearch-project/OpenSearch/pull/17797/files
Problem:
When trying to update a rule by just changing its description, the system incorrectly throws a "duplicate rule" error, even though no duplicate rule is created.
When the rule in any api has the same rule id as an existing rule, it means either we are updating an existing rule or we already have the exact same rule in the system under the same doc id (because id is generated based on rule content), in either case, we are not creating duplicate rules so the system shouldn't throw error.
This PR addressed the above issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.