Fixing auto backport workflow#1845
Merged
VachaShah merged 1 commit intoopensearch-project:mainfrom Jan 4, 2022
Merged
Conversation
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Collaborator
|
Can one of the admins verify this patch? |
saratvemulapalli
approved these changes
Jan 4, 2022
Member
saratvemulapalli
left a comment
saratvemulapalli
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @VachaShah !
Now probably we have to tackle stale branches after the backport PR is merged.
May be can you submit a PR tibdex/backport to add support?
owaiskazi19
approved these changes
Jan 4, 2022
Member
|
Let's test the flow 🎉 |
Contributor
Author
Sure will do! |
This was referenced Jan 5, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah vachshah@amazon.com
Description
This should fix the backport workflow failures since the branch protection is relaxed in PR #1816. I tried with the similar set of permissions on my repo and the workflow ran successfully https://github.com/VachaShah/TestGithubActions/runs/4706516920?check_suite_focus=true. The default permissions are
readfor all the scopes if not specified, for example: https://github.com/opensearch-project/OpenSearch/runs/4702581161?check_suite_focus=trueNote: I will add a backport label to a PR in this repo to verify.
Issues Resolved
#1712
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.