Skip to content

Conversation

@gaobinlong
Copy link
Contributor

Description

Replace the deprecated construction method of TopScoreDocCollectorManager with the new method in Lucene 10.1.0.

Related Issues

Resolves #18394.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Binlong Gao <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 2eab119: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 2eab119: SUCCESS

@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.61%. Comparing base (fe4a98d) to head (2eab119).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../join/query/ParentChildInnerHitContextBuilder.java 0.00% 1 Missing ⚠️
...org/opensearch/index/query/NestedQueryBuilder.java 0.00% 1 Missing ⚠️
...ensearch/search/query/TopDocsCollectorContext.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #18395   +/-   ##
=========================================
  Coverage     72.60%   72.61%           
- Complexity    67682    67706   +24     
=========================================
  Files          5497     5497           
  Lines        311819   311817    -2     
  Branches      45265    45265           
=========================================
+ Hits         226409   226417    +8     
- Misses        66941    66954   +13     
+ Partials      18469    18446   -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 6224b72 into opensearch-project:main May 29, 2025
30 of 33 checks passed
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Jun 8, 2025
…ager with the new method in Lucene (opensearch-project#18395)

* Replace the deprecated construction method of TopScoreDocCollectorManager with the new method

Signed-off-by: Binlong Gao <[email protected]>

* Modify changelog

Signed-off-by: Binlong Gao <[email protected]>

---------

Signed-off-by: Binlong Gao <[email protected]>
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Jun 8, 2025
…ager with the new method in Lucene (opensearch-project#18395)

* Replace the deprecated construction method of TopScoreDocCollectorManager with the new method

Signed-off-by: Binlong Gao <[email protected]>

* Modify changelog

Signed-off-by: Binlong Gao <[email protected]>

---------

Signed-off-by: Binlong Gao <[email protected]>
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 9, 2025
…ager with the new method in Lucene (opensearch-project#18395)

* Replace the deprecated construction method of TopScoreDocCollectorManager with the new method

Signed-off-by: Binlong Gao <[email protected]>

* Modify changelog

Signed-off-by: Binlong Gao <[email protected]>

---------

Signed-off-by: Binlong Gao <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…ager with the new method in Lucene (opensearch-project#18395)

* Replace the deprecated construction method of TopScoreDocCollectorManager with the new method

Signed-off-by: Binlong Gao <[email protected]>

* Modify changelog

Signed-off-by: Binlong Gao <[email protected]>

---------

Signed-off-by: Binlong Gao <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…ager with the new method in Lucene (opensearch-project#18395)

* Replace the deprecated construction method of TopScoreDocCollectorManager with the new method

Signed-off-by: Binlong Gao <[email protected]>

* Modify changelog

Signed-off-by: Binlong Gao <[email protected]>

---------

Signed-off-by: Binlong Gao <[email protected]>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
…ager with the new method in Lucene (opensearch-project#18395)

* Replace the deprecated construction method of TopScoreDocCollectorManager with the new method

Signed-off-by: Binlong Gao <[email protected]>

* Modify changelog

Signed-off-by: Binlong Gao <[email protected]>

---------

Signed-off-by: Binlong Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Other

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The construction method of TopScoreDocCollectorManager in Lucene used by OpenSearch is deprecated

3 participants