[Pull-based Ingestion] Support cluster write blocks #18280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
varunbharadwaj
force-pushed
the
vb/clusterblock
branch
from
e405c89 to
608546c
Compare
Contributor
|
❌ Gradle check result for 608546c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
reviewed
May 13, 2025
server/src/main/java/org/opensearch/indices/pollingingest/StreamPoller.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Outdated
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for 886688e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
varunbharadwaj
force-pushed
the
vb/clusterblock
branch
2 times, most recently
from
7c64364 to
1c58b78
Compare
Contributor
|
❕ Gradle check result for 1c58b78: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18280 +/- ##
============================================
- Coverage 72.56% 72.51% -0.05%
+ Complexity 67391 67360 -31
============================================
Files 5488 5488
Lines 311030 311062 +32
Branches 45216 45217 +1
============================================
- Hits 225687 225570 -117
- Misses 66916 67087 +171
+ Partials 18427 18405 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varunbharadwaj
force-pushed
the
vb/clusterblock
branch
from
1c58b78 to
6964d30
Compare
varunbharadwaj
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
owaiskazi19,
reta and
sachinpkale
as code owners
Contributor
yupeng9
reviewed
May 14, 2025
...n/java/org/opensearch/action/admin/indices/streamingingestion/state/ShardIngestionState.java
Show resolved
Hide resolved
This was referenced May 14, 2025
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
varunbharadwaj
force-pushed
the
vb/clusterblock
branch
from
6964d30 to
b00ceb7
Compare
Contributor
|
❌ Gradle check result for b00ceb7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for b00ceb7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <[email protected]>
varunbharadwaj
force-pushed
the
vb/clusterblock
branch
from
b00ceb7 to
62f3c80
Compare
Contributor
yupeng9
approved these changes
May 14, 2025
This was referenced May 15, 2025
tanik98
pushed a commit
to tanik98/OpenSearch
that referenced
this pull request
May 27, 2025
…ct#18280) * Support cluster write blocks in pull-based ingestion Signed-off-by: Varun Bharadwaj <[email protected]> * Update poller from cluster state applier to listener Signed-off-by: Varun Bharadwaj <[email protected]> * Add unit tests Signed-off-by: Varun Bharadwaj <[email protected]> --------- Signed-off-by: Varun Bharadwaj <[email protected]>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
…ct#18280) * Support cluster write blocks in pull-based ingestion Signed-off-by: Varun Bharadwaj <[email protected]> * Update poller from cluster state applier to listener Signed-off-by: Varun Bharadwaj <[email protected]> * Add unit tests Signed-off-by: Varun Bharadwaj <[email protected]> --------- Signed-off-by: Varun Bharadwaj <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…ct#18280) * Support cluster write blocks in pull-based ingestion Signed-off-by: Varun Bharadwaj <[email protected]> * Update poller from cluster state applier to listener Signed-off-by: Varun Bharadwaj <[email protected]> * Add unit tests Signed-off-by: Varun Bharadwaj <[email protected]> --------- Signed-off-by: Varun Bharadwaj <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…ct#18280) * Support cluster write blocks in pull-based ingestion Signed-off-by: Varun Bharadwaj <[email protected]> * Update poller from cluster state applier to listener Signed-off-by: Varun Bharadwaj <[email protected]> * Add unit tests Signed-off-by: Varun Bharadwaj <[email protected]> --------- Signed-off-by: Varun Bharadwaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for cluster write blocks in pull-based ingestion flow. The stream poller is enhanced to listen to cluster state changes and the poller is paused when a write block is active, and resumed when the write block is removed.
GetIngestionState API is also enhanced to reflect the write block status of the poller.
Related Issues
Resolves #18279
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.