[Backport 3.0] Improve sort-query performance by retaining the default totalHitsThreshold for approximated match_all queries and Fix SimpleSearchIT. testSimpleTerminateAfterTrackTotalHitsUpToSize

[prudhvigodithi]

Description

Backport of #18189 and #18235

Related Issues

Resolves #18206

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for bee5e60: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.55%. Comparing base (ea48ab0) to head (f0acc55).
Report is 7 commits behind head on 3.0.

Files with missing lines	Patch %	Lines
...arch/search/approximate/ApproximateScoreQuery.java	42.85%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                3.0   #18220      +/-   ##
============================================
- Coverage     72.55%   72.55%   -0.01%     
- Complexity    67201    67204       +3     
============================================
  Files          5480     5480              
  Lines        310322   310330       +8     
  Branches      45140    45142       +2     
============================================
- Hits         225162   225153       -9     
- Misses        66748    66809      +61     
+ Partials      18412    18368      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

✅ Gradle check result for 82910cd: SUCCESS

[github-actions]

❌ Gradle check result for f0acc55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for f0acc55: SUCCESS

[prudhvigodithi]

{"run-benchmark-test": "id_4"}

[prudhvigodithi]

Just a follow up to see if we can merge this backport PR to 3.0 branch. NVM I thought benchmark already ran from my above comment #18220 (comment), we can merge this once we have the benchmark result out for 3.1.0
Thanks

[prudhvigodithi]

{"run-benchmark-test": "id_4"}

[prudhvigodithi]

I see the following issue in running the benchmark.

Run aws s3 cp distribution/archives/linux-tar/build/distributions/opensearch-min-$OPENSEARCH_VERSION-linux-x64.tar.gz s3://***/PR-$PR_NUMBER/

The user-provided path distribution/archives/linux-tar/build/distributions/opensearch-min-3.1.0-linux-x64.tar.gz does not exist.

CC @rishabh6788

[rishabh6788]

I see the following issue in running the benchmark.

Run aws s3 cp distribution/archives/linux-tar/build/distributions/opensearch-min-$OPENSEARCH_VERSION-linux-x64.tar.gz s3://***/PR-$PR_NUMBER/

The user-provided path distribution/archives/linux-tar/build/distributions/opensearch-min-3.1.0-linux-x64.tar.gz does not exist.

CC @rishabh6788

Since this workflow triggers on issue_comment, it only runs on main branch.

[prudhvigodithi]

Since this workflow triggers on issue_comment, it only runs on main branch.

In that case we should be good to merge this, Adding @andrross @harshavamsi to please check.