[Bugfix] Fix flakiness in TieredSpilloverCacheStatsIT.testClosingShard()#18204
Merged
andrross merged 2 commits intoopensearch-project:mainfrom May 5, 2025
Merged
Conversation
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
github-actions
bot
added
>test-failure
andrross
reviewed
May 5, 2025
...c/internalClusterTest/java/org/opensearch/cache/common/tier/TieredSpilloverCacheStatsIT.java
Outdated
Show resolved
Hide resolved
…ch/cache/common/tier/TieredSpilloverCacheStatsIT.java Co-authored-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18204 +/- ##
=========================================
Coverage 72.54% 72.55%
- Complexity 67234 67286 +52
=========================================
Files 5476 5476
Lines 310444 310449 +5
Branches 45120 45122 +2
=========================================
+ Hits 225211 225244 +33
- Misses 66834 66858 +24
+ Partials 18399 18347 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
approved these changes
May 5, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 5, 2025
…d() (#18204) * Fix flakiness in testClosingShard() Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Update modules/cache-common/src/internalClusterTest/java/org/opensearch/cache/common/tier/TieredSpilloverCacheStatsIT.java Co-authored-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit aed1264) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
added a commit
that referenced
this pull request
May 8, 2025
…d() (#18204) (#18207) * Fix flakiness in testClosingShard() * Update modules/cache-common/src/internalClusterTest/java/org/opensearch/cache/common/tier/TieredSpilloverCacheStatsIT.java --------- (cherry picked from commit aed1264) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes flakiness in TieredSpilloverCacheStatsIT.testClosingShard() by adding a 50 ms sleep before doing a check. This should ensure the asynchronous cache cleanup logic is always finished before the check.
I'm not totally sure why this only started flaking recently, around April 14. As far as I can tell no relevant code changed around then. Did something change about the way we run tests in Jenkins that might have slowed down the cache cleanup logic?
Related Issues
Resolves #14300
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.