-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Update bundled JDK to JDK-24 #18085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundled JDK to JDK-24 #18085
Conversation
|
❌ Gradle check result for 5d1adf4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5d1adf4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 41381d0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Yes, thanks @kumargu |
I excluded HDFS with security checks for now, will be working on some mitigations but this is not a blocker |
Signed-off-by: Andriy Redko <drreta@gmail.com>
| permission java.io.FilePermission "/sys/fs/cgroup/memory", "read"; | ||
| permission java.io.FilePermission "/sys/fs/cgroup/memory/-", "read"; | ||
| permission java.io.FilePermission "/sys/fs/cgroup/user.slice/-", "read"; | ||
| permission java.io.FilePermission "/sys/fs/cgroup/memory.swap.max", "read"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reta Shouldn't we also add the same for /sys/fs/cgroup/memory.swap.current ?
I see this exception in some output of some tests (they don't fail though_
java.lang.reflect.InvocationTargetException: null
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:119) ~[?:?]
at java.base/java.lang.reflect.Method.invoke(Method.java:565) ~[?:?]
at org.opensearch.monitor.os.OsProbe.getFreeSwapSpaceSize(OsProbe.java:151) [main/:?]
at org.opensearch.monitor.os.OsProbe.osStats(OsProbe.java:694) [main/:?]
at org.opensearch.monitor.os.OsService.<init>(OsService.java:71) [main/:?]
at org.opensearch.monitor.MonitorService.<init>(MonitorService.java:64) [main/:?]
at org.opensearch.node.Node.<init>(Node.java:788) [main/:?]
at org.opensearch.node.MockNode.<init>(MockNode.java:99) [framework-3.1.0-SNAPSHOT.jar:?]
at org.opensearch.node.MockNode.<init>(MockNode.java:109) [framework-3.1.0-SNAPSHOT.jar:?]
at org.opensearch.test.OpenSearchSingleNodeTestCase.newNode(OpenSearchSingleNodeTestCase.java:296) [framework-3.1.0-SNAPSHOT.jar:3.1.0-SNAPSHOT]
...
Caused by: java.lang.SecurityException: Denied OPEN (read) access to file: /sys/fs/cgroup/memory.swap.current, domain: ProtectionDomain (file:/home/nonroot/.gradle/caches/modules-2/files-2.1/junit/junit/4.13.2/8ac9e16d933b6fb43bc7f576336b8f4d7eb5ba12/junit-4.13.2.jar <no signer certificates>)
jdk.internal.loader.ClassLoaders$AppClassLoader@659e0bfd
<no principals>
java.security.Permissions@21c2d0ab (
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…emory.swap.current` See opensearch-project#18085 (comment) Signed-off-by: Mikhail Stepura <mstepura@apple.com>
#18548) See #18085 (comment) Signed-off-by: Mikhail Stepura <mstepura@apple.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
…emory.swap.current` (opensearch-project#18548) See opensearch-project#18085 (comment) Signed-off-by: Mikhail Stepura <mstepura@apple.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
…emory.swap.current` (opensearch-project#18548) See opensearch-project#18085 (comment) Signed-off-by: Mikhail Stepura <mstepura@apple.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
…emory.swap.current` (opensearch-project#18548) See opensearch-project#18085 (comment) Signed-off-by: Mikhail Stepura <mstepura@apple.com>
Description
Update bundled JDK to JDK-24
Blockers so far:
Related Issues
Closes #17661
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.