Skip to content

Conversation

@reta
Copy link
Contributor

@reta reta commented Apr 25, 2025

Description

Update bundled JDK to JDK-24

Blockers so far:

Related Issues

Closes #17661

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for 5d1adf4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 5d1adf4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 41381d0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Contributor Author

reta commented Jun 16, 2025

JDK-24 would be available in 3.2 earliest? Asking because I wanted to try out openjdk/jdk@75f3ec7 optimization .

Yes, thanks @kumargu

@reta
Copy link
Contributor Author

reta commented Jun 16, 2025

Great to see the Gradle checks passing!

I excluded HDFS with security checks for now, will be working on some mitigations but this is not a blocker

@andrross andrross merged commit cc160cb into opensearch-project:main Jun 16, 2025
34 of 35 checks passed
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 17, 2025
Signed-off-by: Andriy Redko <drreta@gmail.com>
permission java.io.FilePermission "/sys/fs/cgroup/memory", "read";
permission java.io.FilePermission "/sys/fs/cgroup/memory/-", "read";
permission java.io.FilePermission "/sys/fs/cgroup/user.slice/-", "read";
permission java.io.FilePermission "/sys/fs/cgroup/memory.swap.max", "read";
Copy link
Contributor

@mishail mishail Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta Shouldn't we also add the same for /sys/fs/cgroup/memory.swap.current ?

I see this exception in some output of some tests (they don't fail though_

java.lang.reflect.InvocationTargetException: null
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:119) ~[?:?]
	at java.base/java.lang.reflect.Method.invoke(Method.java:565) ~[?:?]
	at org.opensearch.monitor.os.OsProbe.getFreeSwapSpaceSize(OsProbe.java:151) [main/:?]
	at org.opensearch.monitor.os.OsProbe.osStats(OsProbe.java:694) [main/:?]
	at org.opensearch.monitor.os.OsService.<init>(OsService.java:71) [main/:?]
	at org.opensearch.monitor.MonitorService.<init>(MonitorService.java:64) [main/:?]
	at org.opensearch.node.Node.<init>(Node.java:788) [main/:?]
	at org.opensearch.node.MockNode.<init>(MockNode.java:99) [framework-3.1.0-SNAPSHOT.jar:?]
	at org.opensearch.node.MockNode.<init>(MockNode.java:109) [framework-3.1.0-SNAPSHOT.jar:?]
	at org.opensearch.test.OpenSearchSingleNodeTestCase.newNode(OpenSearchSingleNodeTestCase.java:296) [framework-3.1.0-SNAPSHOT.jar:3.1.0-SNAPSHOT]
...	
Caused by: java.lang.SecurityException: Denied OPEN (read) access to file: /sys/fs/cgroup/memory.swap.current, domain: ProtectionDomain  (file:/home/nonroot/.gradle/caches/modules-2/files-2.1/junit/junit/4.13.2/8ac9e16d933b6fb43bc7f576336b8f4d7eb5ba12/junit-4.13.2.jar <no signer certificates>)
 jdk.internal.loader.ClassLoaders$AppClassLoader@659e0bfd
 <no principals>
 java.security.Permissions@21c2d0ab (
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta Shouldn't we also add the same for /sys/fs/cgroup/memory.swap.current ?

Thanks @mishail , I think it is good idea, could you open a pull request please? thank you

mishail added a commit to mishail/OpenSearch that referenced this pull request Jun 18, 2025
…emory.swap.current`

See opensearch-project#18085 (comment)

Signed-off-by: Mikhail Stepura <mstepura@apple.com>
reta pushed a commit that referenced this pull request Jun 18, 2025
#18548)

See #18085 (comment)

Signed-off-by: Mikhail Stepura <mstepura@apple.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Signed-off-by: Andriy Redko <drreta@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…emory.swap.current` (opensearch-project#18548)

See opensearch-project#18085 (comment)

Signed-off-by: Mikhail Stepura <mstepura@apple.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Signed-off-by: Andriy Redko <drreta@gmail.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
Signed-off-by: Andriy Redko <drreta@gmail.com>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request skip-changelog v3.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add JDK-24 support

9 participants