Skip to content

Conversation

@Gagan6164
Copy link
Contributor

@Gagan6164 Gagan6164 commented Apr 25, 2025

Description

This pull request introduces the WarmDiskThresholdDecider to handle the allocation and rebalancing of writable warm shards in OpenSearch. The current allocation logic for remote-capable shards is static and works well for searchable snapshot index shards, as their size remains constant. However, for writable warm shards, the size might not remain constant, and we might eventually exceed the total remote addressable size on a node.

Related Issues

Resolves #8535

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for ba29e41: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for bfb230b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for d101c39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Gagan6164 Gagan6164 marked this pull request as ready for review April 30, 2025 09:17
@Gagan6164 Gagan6164 requested a review from a team as a code owner April 30, 2025 09:17
@github-actions
Copy link
Contributor

❌ Gradle check result for 974a850: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Gagan6164 Gagan6164 changed the title Add File Cache Threshold Decider for Writable Warm shards Add Warm Disk Threshold Allocation Decider for Writable Warm shards Apr 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

❌ Gradle check result for 48bbba4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

❌ Gradle check result for 0fa3429: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

❌ Gradle check result for bb12949: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

❌ Gradle check result for 2cd2fe5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Gagan6164 Gagan6164 force-pushed the WarmDiskThresholdDecider branch from 2cd2fe5 to a37f8fd Compare May 5, 2025 09:14
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

❌ Gradle check result for a37f8fd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Gagan Singh Saini added 10 commits May 6, 2025 12:32
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
@Gagan6164 Gagan6164 force-pushed the WarmDiskThresholdDecider branch from a37f8fd to 22d6926 Compare May 6, 2025 07:09
Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

❌ Gradle check result for 284f32c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

❌ Gradle check result for a38825a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

✅ Gradle check result for 7e0b776: SUCCESS

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 76.22951% with 29 lines in your changes missing coverage. Please review.

Project coverage is 72.58%. Comparing base (560ac10) to head (4bd309b).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...g/allocation/decider/WarmDiskThresholdDecider.java 77.47% 13 Missing and 12 partials ⚠️
...ster/routing/allocation/DiskThresholdSettings.java 71.42% 2 Missing ⚠️
...uting/allocation/decider/DiskThresholdDecider.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18082      +/-   ##
============================================
+ Coverage     72.56%   72.58%   +0.01%     
- Complexity    67261    67337      +76     
============================================
  Files          5476     5483       +7     
  Lines        310478   310776     +298     
  Branches      45133    45176      +43     
============================================
+ Hits         225313   225583     +270     
+ Misses        66840    66804      -36     
- Partials      18325    18389      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbbafna gbbafna changed the title Add Warm Disk Threshold Allocation Decider for Writable Warm shards Add Warm Disk Threshold Allocation Decider for Warm shards May 7, 2025
Gagan Singh Saini and others added 2 commits May 7, 2025 11:11
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

❕ Gradle check result for 4800c1d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

✅ Gradle check result for 4bd309b: SUCCESS

@gbbafna gbbafna merged commit c677397 into opensearch-project:main May 9, 2025
30 checks passed
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Jun 26, 2025
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Search:Searchable Snapshots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for a FileCacheDecider

2 participants