-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add Warm Disk Threshold Allocation Decider for Warm shards #18082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Warm Disk Threshold Allocation Decider for Warm shards #18082
Conversation
|
❌ Gradle check result for ba29e41: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bfb230b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for d101c39: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 974a850: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 48bbba4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0fa3429: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bb12949: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 2cd2fe5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2cd2fe5 to
a37f8fd
Compare
|
❌ Gradle check result for a37f8fd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...er/src/main/java/org/opensearch/cluster/routing/allocation/decider/DiskThresholdDecider.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/opensearch/cluster/routing/allocation/decider/WarmDiskThresholdDecider.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/opensearch/cluster/routing/allocation/decider/WarmDiskThresholdDecider.java
Show resolved
Hide resolved
...rc/main/java/org/opensearch/cluster/routing/allocation/decider/WarmDiskThresholdDecider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
a37f8fd to
22d6926
Compare
Signed-off-by: Gagan Singh Saini <[email protected]>
|
❌ Gradle check result for 284f32c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Singh Saini <[email protected]>
|
❌ Gradle check result for a38825a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Singh Saini <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18082 +/- ##
============================================
+ Coverage 72.56% 72.58% +0.01%
- Complexity 67261 67337 +76
============================================
Files 5476 5483 +7
Lines 310478 310776 +298
Branches 45133 45176 +43
============================================
+ Hits 225313 225583 +270
+ Misses 66840 66804 -36
- Partials 18325 18389 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...rc/main/java/org/opensearch/cluster/routing/allocation/decider/WarmDiskThresholdDecider.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/opensearch/cluster/routing/allocation/decider/DiskThresholdDecider.java
Show resolved
Hide resolved
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan6164 <[email protected]>
|
❕ Gradle check result for 4800c1d: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Gaurav Bafna <[email protected]>
…h-project#18082) Signed-off-by: Gagan Singh Saini <[email protected]>
…h-project#18082) Signed-off-by: Gagan Singh Saini <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
Description
This pull request introduces the WarmDiskThresholdDecider to handle the allocation and rebalancing of writable warm shards in OpenSearch. The current allocation logic for remote-capable shards is static and works well for searchable snapshot index shards, as their size remains constant. However, for writable warm shards, the size might not remain constant, and we might eventually exceed the total remote addressable size on a node.
Related Issues
Resolves #8535
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.