Skip to content

Conversation

@10000-ki
Copy link
Contributor

@10000-ki 10000-ki commented Apr 22, 2025

Description

Our current default max header size is 8KB.

related osd issues

When using JWT token-based authentication, an 8KB header size is insufficient.
Elasticsearch encountered the same issue and has increased the default value to 16KB.
see : elastic/elasticsearch#88725

Unless there are any particular concerns, I suggest we do the same and change our default to 16KB as well.

Related Issues

Resolves #18022

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jainankitk
Copy link
Contributor

@10000-ki - Thanks for the code changes. Can you add changelog entry? Also, can you create a documentation issue for this change?

@10000-ki 10000-ki force-pushed the increase-default-header-max-size branch from 8db127c to e9daa2c Compare April 22, 2025 04:58
@10000-ki
Copy link
Contributor Author

Thanks for the code changes. Can you add changelog entry? Also, can you create a documentation issue for this change?

@jainankitk yes sure i will add

@10000-ki
Copy link
Contributor Author

@jainankitk hi~

i created a issue related doc : opensearch-project/documentation-website#9676

also

Once this PR is merged, I’ll try contributing to the documentation side as well.

@github-actions
Copy link
Contributor

❌ Gradle check result for a77cceb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Contributor

Unrelated test failure:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/56834/testReport/) (1 failure / +1)

    [org.opensearch.snapshots.SharedClusterSnapshotRestoreIT.testSnapshotFileFailureDuringSnapshot](https://build.ci.opensearch.org/job/gradle-check/56834/testReport/junit/org.opensearch.snapshots/SharedClusterSnapshotRestoreIT/testSnapshotFileFailureDuringSnapshot/)

Retrying gradle check

@github-actions
Copy link
Contributor

❌ Gradle check result for a77cceb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@10000-ki 10000-ki force-pushed the increase-default-header-max-size branch from a77cceb to 23f2e6b Compare April 22, 2025 08:32
Signed-off-by: 10000-ki <[email protected]>

Add change log

Signed-off-by: 10000-ki <[email protected]>

Remove duplicate line

Signed-off-by: 10000-ki <[email protected]>
@10000-ki 10000-ki force-pushed the increase-default-header-max-size branch from 23f2e6b to 9bf6271 Compare April 22, 2025 08:34
@10000-ki
Copy link
Contributor Author

resolved conflicts

@github-actions
Copy link
Contributor

✅ Gradle check result for 9bf6271: SUCCESS

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.55%. Comparing base (52b8b05) to head (9bf6271).
Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18024      +/-   ##
============================================
+ Coverage     72.42%   72.55%   +0.13%     
- Complexity    67058    67136      +78     
============================================
  Files          5478     5478              
  Lines        310137   310130       -7     
  Branches      45087    45087              
============================================
+ Hits         224610   225016     +406     
+ Misses        67140    66795     -345     
+ Partials      18387    18319      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jainankitk jainankitk merged commit 6afec2a into opensearch-project:main Apr 22, 2025
31 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 23, 2025
Add change log

Remove duplicate line

Signed-off-by: 10000-ki <[email protected]>
(cherry picked from commit 6afec2a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
Add change log

Remove duplicate line

Signed-off-by: 10000-ki <[email protected]>
Signed-off-by: Tanishq Ranjan <[email protected]>
jainankitk added a commit that referenced this pull request Apr 24, 2025
* Increase default http.max_header_size to 16kb (#18024)

Add change log

Remove duplicate line

Signed-off-by: 10000-ki <[email protected]>
(cherry picked from commit 6afec2a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update CHANGELOG.md

Signed-off-by: Ankit Jain <[email protected]>

---------

Signed-off-by: 10000-ki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ankit Jain <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <[email protected]>
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
…earch-project#18061)

* Increase default http.max_header_size to 16kb (opensearch-project#18024)

Add change log

Remove duplicate line

Signed-off-by: 10000-ki <[email protected]>
(cherry picked from commit 6afec2a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update CHANGELOG.md

Signed-off-by: Ankit Jain <[email protected]>

---------

Signed-off-by: 10000-ki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ankit Jain <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
Add change log

Remove duplicate line

Signed-off-by: 10000-ki <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
Add change log

Remove duplicate line

Signed-off-by: 10000-ki <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.0 enhancement Enhancement or improvement to existing feature or request Other

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Increase http.max_header_size default to 16kb

2 participants