-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Increase default http.max_header_size to 16kb
#18024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase default http.max_header_size to 16kb
#18024
Conversation
|
@10000-ki - Thanks for the code changes. Can you add changelog entry? Also, can you create a documentation issue for this change? |
8db127c to
e9daa2c
Compare
@jainankitk yes sure i will add |
|
@jainankitk hi~ i created a issue related doc : opensearch-project/documentation-website#9676 also Once this PR is merged, I’ll try contributing to the documentation side as well. |
|
❌ Gradle check result for a77cceb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Unrelated test failure: Retrying gradle check |
|
❌ Gradle check result for a77cceb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a77cceb to
23f2e6b
Compare
Signed-off-by: 10000-ki <[email protected]> Add change log Signed-off-by: 10000-ki <[email protected]> Remove duplicate line Signed-off-by: 10000-ki <[email protected]>
23f2e6b to
9bf6271
Compare
|
resolved conflicts |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18024 +/- ##
============================================
+ Coverage 72.42% 72.55% +0.13%
- Complexity 67058 67136 +78
============================================
Files 5478 5478
Lines 310137 310130 -7
Branches 45087 45087
============================================
+ Hits 224610 225016 +406
+ Misses 67140 66795 -345
+ Partials 18387 18319 -68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add change log Remove duplicate line Signed-off-by: 10000-ki <[email protected]> (cherry picked from commit 6afec2a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Add change log Remove duplicate line Signed-off-by: 10000-ki <[email protected]> Signed-off-by: Tanishq Ranjan <[email protected]>
* Increase default http.max_header_size to 16kb (#18024) Add change log Remove duplicate line Signed-off-by: 10000-ki <[email protected]> (cherry picked from commit 6afec2a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update CHANGELOG.md Signed-off-by: Ankit Jain <[email protected]> --------- Signed-off-by: 10000-ki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ankit Jain <[email protected]>
…earch-project#18061) * Increase default http.max_header_size to 16kb (opensearch-project#18024) Add change log Remove duplicate line Signed-off-by: 10000-ki <[email protected]> (cherry picked from commit 6afec2a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update CHANGELOG.md Signed-off-by: Ankit Jain <[email protected]> --------- Signed-off-by: 10000-ki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ankit Jain <[email protected]> Signed-off-by: Prudhvi Godithi <[email protected]>
Add change log Remove duplicate line Signed-off-by: 10000-ki <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Add change log Remove duplicate line Signed-off-by: 10000-ki <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Description
Our current default max header size is
8KB.related osd issues
When using JWT token-based authentication, an 8KB header size is insufficient.
Elasticsearch encountered the same issue and has increased the default value to 16KB.
see : elastic/elasticsearch#88725
Unless there are any particular concerns, I suggest we do the same and change our default to
16KBas well.Related Issues
Resolves #18022
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.