[Java Agent Policy Parser] Skip evaluation of AttachPermission

[kumargu]

A quick fix to unblock load of PA plugins which defines Attach Permissions in its policy.

Fixes: opensearch-project/performance-analyzer#795

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[kumargu]

cc @cwperks @andrross

[andrross]

The error seems to be coming from this line:

https://github.com/opensearch-project/OpenSearch/blob/main/libs/agent-sm/agent-policy/src/main/java/org/opensearch/secure_sm/policy/PolicyFile.java#L148

and it's a java.lang.ClassNotFoundException: com/sun/tools/attach/AttachPermission. I don't think this change will fix it, will it?

[andrross]

Right. I overlooked that its ClassNotFoundException. Not sure tho why we would see that. Maybe because packages in sun.tools are not directly visible outside of JDK?

@kumargu My reading of the JDK policy file is that it would handle all class not found exceptions, so the fact this class isn't available to the class loader for whatever reason is probably not new.

[github-actions]

❌ Gradle check result for 1924325: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 1924325: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 1924325: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 1924325: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 1924325: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for fa9d554: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for fa9d554: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.55%. Comparing base (1628152) to head (fa9d554).
Report is 13 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17896      +/-   ##
============================================
+ Coverage     72.43%   72.55%   +0.11%     
- Complexity    66789    66846      +57     
============================================
  Files          5449     5452       +3     
  Lines        309085   309210     +125     
  Branches      44979    44991      +12     
============================================
+ Hits         223899   224343     +444     
+ Misses        66906    66494     -412     
- Partials      18280    18373      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.