-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Pull-based ingestion] Use writer tracked shard pointer for recovery #17868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7c68baf to
c4bdc7d
Compare
|
❌ Gradle check result for c4bdc7d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Outdated
Show resolved
Hide resolved
c4bdc7d to
9e0b808
Compare
|
❌ Gradle check result for 9e0b808: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 9e0b808: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/java/org/opensearch/index/engine/IngestionEngineTests.java
Show resolved
Hide resolved
|
❌ Gradle check result for 9e0b808: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/pollingingest/MessageProcessorRunnable.java
Show resolved
Hide resolved
9e0b808 to
00cf587
Compare
|
❌ Gradle check result for 00cf587: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 00cf587: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <[email protected]>
00cf587 to
677b3d9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17868 +/- ##
============================================
- Coverage 72.43% 72.43% -0.01%
- Complexity 66789 66815 +26
============================================
Files 5449 5452 +3
Lines 309085 309198 +113
Branches 44979 44988 +9
============================================
+ Hits 223899 223957 +58
- Misses 66906 66912 +6
- Partials 18280 18329 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…17868) Signed-off-by: Varun Bharadwaj <[email protected]> Signed-off-by: Sriram Ganesh <[email protected]>
…17868) Signed-off-by: Varun Bharadwaj <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
…17868) Signed-off-by: Varun Bharadwaj <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
…17868) Signed-off-by: Varun Bharadwaj <[email protected]>
Description
This PR fixes a bug in the pull-based ingestion flow where some messages can be skipped in some scenarios on shard recovery. The fix is to track the shard pointer on the writer thread and use that as the start point for recovery.
Additionally, this PR also avoids failing entire batch if one record fails and lets the error policy decide when to pause ingestion.
Related Issues
Resolves #17853
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.