-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add a builder to ingestion source #17814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yupeng Fu <[email protected]>
|
❌ Gradle check result for 3dd7845: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 3dd7845: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17814 +/- ##
============================================
+ Coverage 72.39% 72.41% +0.02%
- Complexity 66066 66299 +233
============================================
Files 5358 5384 +26
Lines 306500 307164 +664
Branches 44409 44555 +146
============================================
+ Hits 221888 222441 +553
- Misses 66474 66575 +101
- Partials 18138 18148 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mch2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Yupeng Fu <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Description
As
IngestionSourcetakes more arguments, it's better to change the constructor to a builder patternBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.