Skip to content

Conversation

@yupeng9
Copy link
Contributor

@yupeng9 yupeng9 commented Apr 7, 2025

Description

As IngestionSource takes more arguments, it's better to change the constructor to a builder pattern

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

❌ Gradle check result for 3dd7845: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❕ Gradle check result for 3dd7845: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (2d42bd0) to head (3dd7845).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/cluster/metadata/IngestionSource.java 57.89% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17814      +/-   ##
============================================
+ Coverage     72.39%   72.41%   +0.02%     
- Complexity    66066    66299     +233     
============================================
  Files          5358     5384      +26     
  Lines        306500   307164     +664     
  Branches      44409    44555     +146     
============================================
+ Hits         221888   222441     +553     
- Misses        66474    66575     +101     
- Partials      18138    18148      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mch2 mch2 merged commit 0d86ac1 into opensearch-project:main Apr 8, 2025
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants