Skip to content

[Backport 2.x] [bug fix] fix precompute ordering in max & min aggregator #17646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
opensearch-trigger-bot wants to merge 1 commit into from
Closed

[Backport 2.x] [bug fix] fix precompute ordering in max & min aggregator #17646

opensearch-trigger-bot wants to merge 1 commit into from

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Mar 20, 2025

Backport cdcfcbc from #17505.

@github-actions
fix precompute ordering for min & max aggregators (#17505)
753ccef 
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
(cherry picked from commit cdcfcbc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sandeshkr419 sandeshkr419 added bug Something isn't working skip-changelog Performance This is for any performance related enhancements or bugs labels Mar 20, 2025
@sandeshkr419 sandeshkr419 self-assigned this Mar 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

✅ Gradle check result for 753ccef: SUCCESS

@codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.98%. Comparing base (87b4b91) to head (753ccef).
⚠️ Report is 13 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rch/search/aggregations/metrics/MaxAggregator.java 25.00% 5 Missing and 1 partial ⚠️
...rch/search/aggregations/metrics/MinAggregator.java 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17646      +/-   ##
============================================
- Coverage     72.02%   71.98%   -0.04%     
+ Complexity    66032    66021      -11     
============================================
  Files          5342     5342              
  Lines        307289   307289              
  Branches      44848    44848              
============================================
- Hits         221316   221214     -102     
- Misses        67505    67615     +110     
+ Partials      18468    18460       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sandeshkr419
sandeshkr419 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@sandeshkr419 sandeshkr419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17505 (comment)

@opensearch-trigger-bot
Copy link
Contributor Author

opensearch-trigger-bot bot commented Apr 21, 2025

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Apr 21, 2025
@opensearch-trigger-bot
Copy link
Contributor Author

opensearch-trigger-bot bot commented May 22, 2025

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels May 22, 2025
@opensearch-trigger-bot
Copy link
Contributor Author

opensearch-trigger-bot bot commented Jun 23, 2025

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 23, 2025
@sandeshkr419
Copy link
Member

sandeshkr419 commented Jun 23, 2025

@msfroh Based on our offline conversations in the past, I remember you mentioned that we don't need to backport this for experimental feature.
In that case, should we close this up?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jun 29, 2025
@github-actions github-actions bot deleted the backport/backport-17505-to-2.x branch October 22, 2025 06:48
@sandeshkr419
Copy link
Member

sandeshkr419 commented Oct 22, 2025 •
edited
Loading

Closing as star-tree is now out of experimental in 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandeshkr419 sandeshkr419 sandeshkr419 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

@sandeshkr419 sandeshkr419

Labels

bug Something isn't working Performance This is for any performance related enhancements or bugs skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sandeshkr419