Add test for stale writer correctness with pinned timestamp snapshots #17547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Singh <[email protected]>
ashking94
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
sachinpkale
approved these changes
Mar 7, 2025
Contributor
|
❌ Gradle check result for b1dfd68: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❕ Gradle check result for b1dfd68: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17547 +/- ##
============================================
+ Coverage 71.54% 72.41% +0.87%
- Complexity 64883 65698 +815
============================================
Files 5311 5311
Lines 304903 304941 +38
Branches 44215 44228 +13
============================================
+ Hits 218133 220814 +2681
+ Misses 68896 66058 -2838
- Partials 17874 18069 +195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
…#17547) Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit ffa46ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94
pushed a commit
that referenced
this pull request
Mar 7, 2025
…#17547) (#17550) (cherry picked from commit ffa46ca) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Mar 18, 2025
…opensearch-project#17547) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a unit test for handling the case of choosing the correct metadata file when there are metadata files created by stale writer which has higher timestamp than correct writer (which has higher primary term) but below the pinned timestamp. This test checks that the timestamp picked is always the one with highest primary term.
Accidentally closed #17536 and created this PR.
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.