Skip to content

Change IOContext from READONCE to DEFAULT to avoid WrongThreadException (#17502) #17544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sachinpkale merged 1 commit into from
Mar 10, 2025
Merged

Change IOContext from READONCE to DEFAULT to avoid WrongThreadException (#17502) #17544

sachinpkale merged 1 commit into from
Mar 10, 2025

Conversation

@sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Mar 7, 2025

Backport 588f46d from #17502

@sachinpkale sachinpkale self-assigned this Mar 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

❌ Gradle check result for c416354: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

❌ Gradle check result for c416354: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

❌ Gradle check result for c416354: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Mar 7, 2025
Open
Open
Closed
Open
Open
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

❌ Gradle check result for c416354: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Mar 10, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

✅ Gradle check result for c416354: SUCCESS

@codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (efde476) to head (c416354).
Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
...va/org/opensearch/index/store/RemoteDirectory.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17544      +/-   ##
============================================
+ Coverage     71.91%   72.01%   +0.09%     
- Complexity    65941    66000      +59     
============================================
  Files          5342     5342              
  Lines        307287   307288       +1     
  Branches      44849    44849              
============================================
+ Hits         220997   221289     +292     
+ Misses        67862    67515     -347     
- Partials      18428    18484      +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sachinpkale sachinpkale merged commit cf525b2 into opensearch-project:2.x Mar 10, 2025
69 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashking94 ashking94 ashking94 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

@sachinpkale sachinpkale

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sachinpkale @ashking94