Skip to content

Conversation

@kaushalmahi12
Copy link
Contributor

@kaushalmahi12 kaushalmahi12 commented Feb 12, 2025

Description

This change will allow us to store prefix based string values in-memory structures. This will be fundamental to process Rules or any prefix based structure in memory.

Changes in this PR

  • It introduces an interface for allowing prefix based string manipulation
  • It adds a Patricia Trie based implementation of the above interface and includes UTs

Related Issues

#16797 (comment)

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for f575fbd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 24c4ea6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for acdb27c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 4fd6e66: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kaushalmahi12
Copy link
Contributor Author

kaushalmahi12 commented Feb 21, 2025

:distribution:bwc:staged:buildBwcLinuxTar
 Building 2.19.0 didn't generate expected file /Users/kshkmr/opensource/OpenSearch/distribution/bwc/staged/build/bwc/checkout-2.19/distribution/archives/linux-tar/build/distributions/opensearch-min-2.19.0-SNAPSHOT-linux-x64.tar.gz

The build seems to be failing because it is creating a 2.19.1 tar but expecting 2.19.0. Will resync with the mainline first to see if it works

@github-actions
Copy link
Contributor

❌ Gradle check result for e944e6a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 55e613d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (8447737) to head (cedf10d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...n/wlm/rule/storage/DefaultAttributeValueStore.java 92.59% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17342      +/-   ##
============================================
- Coverage     72.48%   72.38%   -0.11%     
  Complexity    65637    65637              
============================================
  Files          5303     5304       +1     
  Lines        304793   304820      +27     
  Branches      44202    44206       +4     
============================================
- Hits         220926   220631     -295     
- Misses        65711    66087     +376     
+ Partials      18156    18102      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kaushal Kumar <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for cedf10d: SUCCESS

@jainankitk jainankitk merged commit 4648c3f into opensearch-project:main Feb 24, 2025
30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 24, 2025
* [rule based autotagging] add attribute value store

Signed-off-by: Kaushal Kumar <[email protected]>

* add CHANGELOG entry

Signed-off-by: Kaushal Kumar <[email protected]>

* make the store interface generic

Signed-off-by: Kaushal Kumar <[email protected]>

* run spotless apply

Signed-off-by: Kaushal Kumar <[email protected]>

* add missing javadoc

Signed-off-by: Kaushal Kumar <[email protected]>

* improve javadoc for attribute value store

Signed-off-by: Kaushal Kumar <[email protected]>

* improve binary search bisecting expression

Signed-off-by: Kaushal Kumar <[email protected]>

* add licenses directory

Signed-off-by: Kaushal Kumar <[email protected]>

---------

Signed-off-by: Kaushal Kumar <[email protected]>
(cherry picked from commit 4648c3f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks added a commit that referenced this pull request Feb 27, 2025
* [rule based autotagging] add attribute value store



* add CHANGELOG entry



* make the store interface generic



* run spotless apply



* add missing javadoc



* improve javadoc for attribute value store



* improve binary search bisecting expression



* add licenses directory



---------


(cherry picked from commit 4648c3f)

Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants