-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[rule based autotagging] add attribute value store #17342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rule based autotagging] add attribute value store #17342
Conversation
|
❌ Gradle check result for f575fbd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java
Outdated
Show resolved
Hide resolved
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Show resolved
Hide resolved
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java
Outdated
Show resolved
Hide resolved
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 24c4ea6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for acdb27c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
b489eab to
4fd6e66
Compare
|
❌ Gradle check result for 4fd6e66: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The build seems to be failing because it is creating a 2.19.1 tar but expecting 2.19.0. Will resync with the mainline first to see if it works |
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
4fd6e66 to
e944e6a
Compare
|
❌ Gradle check result for e944e6a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e944e6a to
55e613d
Compare
|
❕ Gradle check result for 55e613d: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17342 +/- ##
============================================
- Coverage 72.48% 72.38% -0.11%
Complexity 65637 65637
============================================
Files 5303 5304 +1
Lines 304793 304820 +27
Branches 44202 44206 +4
============================================
- Hits 220926 220631 -295
- Misses 65711 66087 +376
+ Partials 18156 18102 -54 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kaushal Kumar <[email protected]>
55e613d to
cedf10d
Compare
* [rule based autotagging] add attribute value store Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * make the store interface generic Signed-off-by: Kaushal Kumar <[email protected]> * run spotless apply Signed-off-by: Kaushal Kumar <[email protected]> * add missing javadoc Signed-off-by: Kaushal Kumar <[email protected]> * improve javadoc for attribute value store Signed-off-by: Kaushal Kumar <[email protected]> * improve binary search bisecting expression Signed-off-by: Kaushal Kumar <[email protected]> * add licenses directory Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> (cherry picked from commit 4648c3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [rule based autotagging] add attribute value store * add CHANGELOG entry * make the store interface generic * run spotless apply * add missing javadoc * improve javadoc for attribute value store * improve binary search bisecting expression * add licenses directory --------- (cherry picked from commit 4648c3f) Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <[email protected]>
Description
This change will allow us to store prefix based string values in-memory structures. This will be fundamental to process Rules or any prefix based structure in memory.
Changes in this PR
Related Issues
#16797 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.