Skip to content

Conversation

@reta
Copy link
Contributor

@reta reta commented Jan 30, 2025

Description

Update 2.x to 2.20.0

Related Issues

Part of #16516

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for 2158fb0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Andriy Redko <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 4bad4ef: SUCCESS

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.98%. Comparing base (2187369) to head (4bad4ef).
Report is 8 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x   #17209   +/-   ##
=========================================
  Coverage     71.98%   71.98%           
+ Complexity    65987    65970   -17     
=========================================
  Files          5341     5341           
  Lines        307114   307153   +39     
  Branches      44824    44822    -2     
=========================================
+ Hits         221068   221110   +42     
+ Misses        67608    67596   -12     
- Partials      18438    18447    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross
Copy link
Member

Assuming we go ahead with the 3.0 release and we do not end up releasing a 2.20 version, then what should we do here? I think it has been unnecessary to keep maintaining the 1.x branch (with version 1.4) for the entire lifecycle of the 2.x version when we had no plans for a 1.4 release. I'm thinking we should not continue with that same pattern once 3.0 is out.

Would just like to start the discussion here even though things are not 100% finalized just yet, so it might be the right thing to merge this PR in the short term then follow on with a cleanup of the 2.x branch after the first 3.0 release.

@reta
Copy link
Contributor Author

reta commented Jan 31, 2025

Would just like to start the discussion here even though things are not 100% finalized just yet, so it might be the right thing to merge this PR in the short term then follow on with a cleanup of the 2.x branch after the first 3.0 release.

@andrross sure, we could discuss that, but the 2.x builds do override 2.19 snapshots at the moment. I think we could bump the version to mitigate the issues and than drop 2.x branch completely (subject to discussion). It is a bit disruptive change. Thank you!

@reta reta merged commit 972b0a7 into opensearch-project:2.x Jan 31, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants