Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support searching from doc_value using termQueryCaseInsensitive/termQuery in flat_object/keyword field #16974

Merged

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Jan 7, 2025

Description

Support searching from doc_value using termQueryCaseInsensitive/termQuery in flat_object/keyword field, even if index=false

Related Issues

Resolves #16973

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc labels Jan 7, 2025
@kkewwei kkewwei force-pushed the flat_object_support_doc_vale branch from 149d559 to 73b3f77 Compare January 7, 2025 14:23
Copy link
Contributor

github-actions bot commented Jan 7, 2025

❌ Gradle check result for 73b3f77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…in flat_object/keyword field

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
@kkewwei kkewwei force-pushed the flat_object_support_doc_vale branch from 73b3f77 to a6945d1 Compare January 8, 2025 02:44
Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ Gradle check result for a6945d1: SUCCESS

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (e7e19f7) to head (a6945d1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rg/opensearch/index/mapper/KeywordFieldMapper.java 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16974      +/-   ##
============================================
- Coverage     72.20%   72.16%   -0.05%     
+ Complexity    65289    65254      -35     
============================================
  Files          5299     5299              
  Lines        303536   303550      +14     
  Branches      43941    43944       +3     
============================================
- Hits         219180   219062     -118     
- Misses        66441    66542     +101     
- Partials      17915    17946      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh added the backport 2.x Backport to 2.x branch label Jan 9, 2025
@msfroh msfroh merged commit cc990c0 into opensearch-project:main Jan 9, 2025
40 of 41 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16974-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cc990c024fe5305f40daa6a1991cd3d9fa21467c
# Push it to GitHub
git push --set-upstream origin backport/backport-16974-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16974-to-2.x.

@msfroh msfroh added the v2.19.0 Issues and PRs related to version 2.19.0 label Jan 10, 2025
@kkewwei kkewwei deleted the flat_object_support_doc_vale branch January 10, 2025 02:41
@kkewwei kkewwei restored the flat_object_support_doc_vale branch January 10, 2025 02:41
@kkewwei
Copy link
Contributor Author

kkewwei commented Jan 10, 2025

I will backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v2.19.0 Issues and PRs related to version 2.19.0
Projects
None yet
2 participants