Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix remote shards balance #16972

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

backport #15335

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Fix remote shards balance

Signed-off-by: panguixin <[email protected]>

* add changelog

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit b359dd8)
Copy link
Contributor

github-actions bot commented Jan 7, 2025

❌ Gradle check result for fc51b60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@kotwanikunal kotwanikunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bugmakerrrrrr!

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ Gradle check result for fc51b60: SUCCESS

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (cb23744) to head (fc51b60).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ing/allocation/allocator/RemoteShardsBalancer.java 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16972      +/-   ##
============================================
+ Coverage     71.86%   71.90%   +0.04%     
- Complexity    65521    65585      +64     
============================================
  Files          5314     5314              
  Lines        305467   305472       +5     
  Branches      44509    44511       +2     
============================================
+ Hits         219518   219655     +137     
+ Misses        67669    67491     -178     
- Partials      18280    18326      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

❌ Gradle check result for db04416: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants