Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 16890: Hide Stracktrace while translog transfer #16891

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

meet-v25
Copy link

@meet-v25 meet-v25 commented Dec 20, 2024

Description

When uploading translog files to remote store, if any translog file upload fails, the user can see the entire stacktrace of the error occurred. This can also reveal the remote file system's exceptions details. This code-change will hide the details of those exceptions and stacktrace about remote filesystems which should not be visible to users in a response.

Related Issues

Resolves #16890

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for 13db4bf: SUCCESS

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (bbcbd21) to head (6ac089a).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16891      +/-   ##
============================================
- Coverage     72.36%   72.22%   -0.14%     
+ Complexity    65373    65276      -97     
============================================
  Files          5299     5299              
  Lines        303510   303511       +1     
  Branches      43945    43945              
============================================
- Hits         219633   219221     -412     
- Misses        65920    66341     +421     
+ Partials      17957    17949       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

❌ Gradle check result for 37f17ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 9, 2025

❌ Gradle check result for 09086ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale
Copy link
Member

Few comments on the PR title and description:

  1. Instead of Fix Issue 16890 in the title, just use [BugFix] followed by PR title.
  2. In the Check List, to select the box, you need to provide [x] to keep it de-secleted, use [ ] (I have made this change)

Copy link
Contributor

✅ Gradle check result for 6ac089a: SUCCESS

@meet-v25
Copy link
Author

Few comments on the PR title and description:

  1. Instead of Fix Issue 16890 in the title, just use [BugFix] followed by PR title.
  2. In the Check List, to select the box, you need to provide [x] to keep it de-secleted, use [ ] (I have made this change)

Thanks for the guidance! Corrected the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Storage:Remote
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

[BUG] Stacktrace visible to end-users while performing translog upload
3 participants