-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 16890: Hide Stracktrace while translog transfer #16891
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16891 +/- ##
============================================
- Coverage 72.36% 72.22% -0.14%
+ Complexity 65373 65276 -97
============================================
Files 5299 5299
Lines 303510 303511 +1
Branches 43945 43945
============================================
- Hits 219633 219221 -412
- Misses 65920 66341 +421
+ Partials 17957 17949 -8 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for 37f17ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/translog/transfer/TranslogTransferManager.java
Show resolved
Hide resolved
❌ Gradle check result for 09086ab: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Few comments on the PR title and description:
|
Thanks for the guidance! Corrected the title. |
Description
When uploading translog files to remote store, if any translog file upload fails, the user can see the entire stacktrace of the error occurred. This can also reveal the remote file system's exceptions details. This code-change will hide the details of those exceptions and stacktrace about remote filesystems which should not be visible to users in a response.
Related Issues
Resolves #16890
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.