Search dv only IP masks #16628
Merged
Search dv only IP masks #16628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhludnev
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
8 tasks
|
❌ Gradle check result for bf572a8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
reviewed
Nov 13, 2024
server/src/main/java/org/opensearch/index/mapper/IpFieldMapper.java
Outdated
Show resolved
Hide resolved
|
@mkhludnev Could you please add entry to CHANGELOG.md for this change? thank you |
reta
added
backport 2.x
Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: mikhail-khludnev <[email protected]>
|
❌ Gradle check result for f7eecfc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: mikhail-khludnev <[email protected]>
|
❌ Gradle check result for a859408: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: mikhail-khludnev <[email protected]>
|
❕ Gradle check result for fa14302: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16628 +/- ##
============================================
+ Coverage 72.03% 72.11% +0.08%
- Complexity 65169 65232 +63
============================================
Files 5318 5318
Lines 303890 303895 +5
Branches 43968 43972 +4
============================================
+ Hits 218906 219155 +249
+ Misses 67051 66773 -278
- Partials 17933 17967 +34 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 12, 2024
reta
reviewed
Nov 14, 2024
server/src/main/java/org/opensearch/index/mapper/IpFieldMapper.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Nov 14, 2024
server/src/main/java/org/opensearch/index/mapper/IpFieldMapper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: mikhail-khludnev <[email protected]>
reta
approved these changes
Nov 15, 2024
|
@msfroh LGTY? thanks! |
msfroh
approved these changes
Nov 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
* search dv only ip masks Signed-off-by: mikhail-khludnev <[email protected]> * search dv only ip masks: changes Signed-off-by: Mikhail Khludnev <[email protected]> * drop fancy closures Signed-off-by: mikhail-khludnev <[email protected]> * drop fancy closures. one more Signed-off-by: mikhail-khludnev <[email protected]> * fix unit tests; add some more dvOnly Signed-off-by: mikhail-khludnev <[email protected]> * drop skipping dvOnly in 2.x Signed-off-by: mikhail-khludnev <[email protected]> * drop redundant brackets Signed-off-by: mikhail-khludnev <[email protected]> * extract conditions Signed-off-by: mikhail-khludnev <[email protected]> * asserts Signed-off-by: mikhail-khludnev <[email protected]> * spotless apply Signed-off-by: mikhail-khludnev <[email protected]> * bring back skip before Signed-off-by: mikhail-khludnev <[email protected]> * combine asserts Signed-off-by: mikhail-khludnev <[email protected]> * inline, copy-paste Signed-off-by: mikhail-khludnev <[email protected]> --------- Signed-off-by: mikhail-khludnev <[email protected]> Signed-off-by: Mikhail Khludnev <[email protected]> Co-authored-by: mikhail-khludnev <[email protected]> (cherry picked from commit d4d70d8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Nov 16, 2024
* search dv only ip masks * search dv only ip masks: changes * drop fancy closures * drop fancy closures. one more * fix unit tests; add some more dvOnly * drop skipping dvOnly in 2.x * drop redundant brackets * extract conditions * asserts * spotless apply * bring back skip before * combine asserts * inline, copy-paste --------- (cherry picked from commit d4d70d8) Signed-off-by: mikhail-khludnev <[email protected]> Signed-off-by: Mikhail Khludnev <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: mikhail-khludnev <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it fixes an edge case when docvalues-only (index:false) IP field is queried via IP mask (1.2.3.4/22 syntax). Now such query is ignored, this change makes it work.
Related Issues
relate #11508
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.