Skip to content

Extend ./bin/opensearch-plugin install <plugin_name> to include plugins in the default distribution#16597

Closed
cwperks wants to merge 2 commits intoopensearch-project:mainfrom
cwperks:make-default-official
Closed

Extend ./bin/opensearch-plugin install <plugin_name> to include plugins in the default distribution#16597
cwperks wants to merge 2 commits intoopensearch-project:mainfrom
cwperks:make-default-official

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Nov 7, 2024

Description

This PR adds all plugins from the default distribution to the official plugin list in OpenSearch core which enables installation by plugin name.

i.e. This command will work after this change.

./bin/opensearch-plugin install opensearch-security

Related Issues

Related to #16195

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Copy link
Member Author

cwperks commented Nov 7, 2024

@reta I decided to open this PR which is related to #16581. Between this PR and supporting snapshots for native plugins, these 2 PRs will make it so that you can install any native or default plugin using the opensearch-plugin CLI and it would work with either release or snapshot build.

@reta
Copy link
Contributor

reta commented Nov 7, 2024

@reta I decided to open this PR which is related to #16581. Between this PR and supporting snapshots for native plugins, these 2 PRs will make it so that you can install any native or default plugin using the opensearch-plugin CLI and it would work with either release or snapshot build.

@cwperks I am not sure I follow: the official plugins are installed by name (and signed). Any other plugins are installed using file:// location or URL - those are not official plugins, not signed.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Gradle check result for 9653ff2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member Author

cwperks commented Nov 7, 2024

@reta I decided to open this PR which is related to #16581. Between this PR and supporting snapshots for native plugins, these 2 PRs will make it so that you can install any native or default plugin using the opensearch-plugin CLI and it would work with either release or snapshot build.

@cwperks I am not sure I follow: the official plugins are installed by name (and signed). Any other plugins are installed using file:// location or URL - those are not official plugins, not signed.

Got it. I will close this PR. I am not familiar with the signing process, but I did encounter that when testing out this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants