Detect Breaking Changes check does not fail on new method added to an @PublicApi interface #16585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…publicapi interface Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
bug
|
❌ Gradle check result for bea3746: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16585 +/- ##
============================================
- Coverage 72.04% 72.01% -0.04%
+ Complexity 65093 65040 -53
============================================
Files 5314 5314
Lines 303541 303541
Branches 43921 43921
============================================
- Hits 218683 218580 -103
- Misses 66946 67022 +76
- Partials 17912 17939 +27 ☔ View full report in Codecov by Sentry. |
|
@peternied mind please to help me here? thank you! :-) |
peternied
approved these changes
Nov 7, 2024
Nope :) At least as of now |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
…publicapi interface (#16585) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit aa5c39b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Nov 7, 2024
…publicapi interface (#16585) (#16587) (cherry picked from commit aa5c39b) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
japicmpplugin was configured to fail only on binary incompatible changes (which new interface method isn't), making checks strick by failing on source incompatible changes.Related Issues
Closes #16175
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.