Skip to content

Adds Integration Tests for Search Pipeline - #16561

Merged
msfroh merged 2 commits into
opensearch-project:mainfrom
owaiskazi19:search-pipeline-IT
Nov 11, 2024
Merged

Adds Integration Tests for Search Pipeline#16561
msfroh merged 2 commits into
opensearch-project:mainfrom
owaiskazi19:search-pipeline-IT

Conversation

@owaiskazi19

@owaiskazi19 owaiskazi19 commented Nov 5, 2024

Copy link
Copy Markdown
Member

Description

Adds Integration Tests for Search Pipeline

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19

owaiskazi19 commented Nov 5, 2024

Copy link
Copy Markdown
Member Author

@msfroh @dbwiddis @saratvemulapalli can you take a look?

@owaiskazi19
owaiskazi19 force-pushed the search-pipeline-IT branch 2 times, most recently from 1b84e5b to 53ae28a Compare November 5, 2024 01:25
@github-actions

github-actions Bot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 53ae28a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19
Adds Integration Tests for Search Pipeline
98dfb5b 
Signed-off-by: Owais <owaiskazi19@gmail.com>
@github-actions

github-actions Bot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

✅ Gradle check result for 98dfb5b: SUCCESS

@codecov

codecov Bot commented Nov 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.12%. Comparing base (0363aa7) to head (160611f).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16561      +/-   ##
============================================
+ Coverage     72.00%   72.12%   +0.11%     
- Complexity    65038    65104      +66     
============================================
  Files          5313     5313              
  Lines        303454   303469      +15     
  Branches      43910    43910              
============================================
+ Hits         218510   218876     +366     
+ Misses        67040    66672     -368     
- Partials      17904    17921      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbwiddis
dbwiddis approved these changes Nov 5, 2024
View reviewed changes

@dbwiddis dbwiddis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay more tests!

andrross
andrross reviewed Nov 5, 2024
View reviewed changes

@andrross andrross left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding some tests! Apologies in advance for the nitpicking :)

Comment thread ...c/internalClusterTest/java/org/opensearch/search/pipeline/common/SearchPipelineCommonIT.java Outdated
Comment thread ...c/internalClusterTest/java/org/opensearch/search/pipeline/common/SearchPipelineCommonIT.java Outdated
Comment thread ...c/internalClusterTest/java/org/opensearch/search/pipeline/common/SearchPipelineCommonIT.java Outdated
@owaiskazi19
Addressed comments
160611f 
Signed-off-by: Owais <owaiskazi19@gmail.com>
@owaiskazi19
owaiskazi19 requested a review from andrross November 5, 2024 21:00
msfroh
msfroh reviewed Nov 5, 2024
View reviewed changes

@msfroh msfroh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are flexing core functionality (default pipelines, update configuration, etc). Do they belong in the integ tests for the search-pipeline-common module? Of course, testing that stuff from core is tricky, because there are no processors registered in core.

As @dbwiddis said, "Yay more tests!" -- while I'd love to see core functionality tested from core, I'm also happy to see integ tests for core functionality in this module (since that's a lot better than not having integ tests anywhere).

@github-actions

github-actions Bot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

✅ Gradle check result for 160611f: SUCCESS

@owaiskazi19

owaiskazi19 commented Nov 5, 2024

Copy link
Copy Markdown
Member Author

These tests are flexing core functionality (default pipelines, update configuration, etc). Do they belong in the integ tests for the search-pipeline-common module? Of course, testing that stuff from core is tricky, because there are no processors registered in core.

Do you think this is not the right place to add these tests? The reason you mentioned above was the sole reason I added it in search-pipeline-common.

@owaiskazi19
owaiskazi19 requested a review from msfroh November 5, 2024 23:29
@msfroh
msfroh merged commit 46ded36 into opensearch-project:main Nov 11, 2024
@owaiskazi19 owaiskazi19 added the backport 2.x Backport to 2.x branch label Nov 11, 2024
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Nov 11, 2024
@github-actions
Adds Integration Tests for Search Pipeline (#16561)
1a19971 
* Adds Integration Tests for Search Pipeline

Signed-off-by: Owais <owaiskazi19@gmail.com>

* Addressed comments

Signed-off-by: Owais <owaiskazi19@gmail.com>

---------

Signed-off-by: Owais <owaiskazi19@gmail.com>
(cherry picked from commit 46ded36)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot Bot mentioned this pull request Nov 11, 2024
Merged
owaiskazi19 pushed a commit that referenced this pull request Nov 12, 2024
@opensearch-trigger-bot @github-actions
Adds Integration Tests for Search Pipeline (#16561) (#16618)
28826a1 
* Adds Integration Tests for Search Pipeline



* Addressed comments



---------


(cherry picked from commit 46ded36)

Signed-off-by: Owais <owaiskazi19@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jan 21, 2025
@owaiskazi19 @akolarkunnu
Adds Integration Tests for Search Pipeline (opensearch-project#16561)
a284701 
* Adds Integration Tests for Search Pipeline

Signed-off-by: Owais <owaiskazi19@gmail.com>

* Addressed comments

Signed-off-by: Owais <owaiskazi19@gmail.com>

---------

Signed-off-by: Owais <owaiskazi19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msfroh msfroh msfroh approved these changes
@dbwiddis dbwiddis dbwiddis approved these changes
@anasalkouz anasalkouz Awaiting requested review from anasalkouz
@ashking94 ashking94 Awaiting requested review from ashking94
@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar
@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE
@dblock dblock Awaiting requested review from dblock
@gbbafna gbbafna Awaiting requested review from gbbafna
@jainankitk jainankitk Awaiting requested review from jainankitk
@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal
@linuxpi linuxpi Awaiting requested review from linuxpi
@mch2 mch2 Awaiting requested review from mch2
@nknize nknize Awaiting requested review from nknize
@reta reta Awaiting requested review from reta
@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159
@sachinpkale sachinpkale Awaiting requested review from sachinpkale
@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli
@shwetathareja shwetathareja Awaiting requested review from shwetathareja
@sohami sohami Awaiting requested review from sohami
@VachaShah VachaShah Awaiting requested review from VachaShah
@andrross andrross Awaiting requested review from andrross
+1 more reviewer
@joshpalis joshpalis joshpalis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@owaiskazi19 @msfroh @andrross @dbwiddis @joshpalis