Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Snapshot V2] Do orphan timestamp cleanup before completing the snapshot #16385

Merged
merged 1 commit into from
Oct 19, 2024
Merged

[Backport 2.x] [Snapshot V2] Do orphan timestamp cleanup before completing the snapshot #16385

merged 1 commit into from
Oct 19, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f1c98a4 from #16365.

@github-actions
Do orphan timestamp cleanup before completing the snapshot (#16365)
68b1f4f 
Signed-off-by: Gaurav Bafna <[email protected]>
(cherry picked from commit f1c98a4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 68b1f4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 18, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 68b1f4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 68b1f4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 19, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 68b1f4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 68b1f4f: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (6db8124) to head (68b1f4f).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16385      +/-   ##
============================================
- Coverage     71.82%   71.81%   -0.02%     
+ Complexity    65108    65085      -23     
============================================
  Files          5304     5304              
  Lines        304138   304135       -3     
  Branches      44232    44231       -1     
============================================
- Hits         218446   218409      -37     
+ Misses        67535    67477      -58     
- Partials      18157    18249      +92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 19, 2024
Closed
@dbwiddis dbwiddis merged commit 96fdbfd into 2.x Oct 19, 2024
63 of 65 checks passed
@github-actions github-actions bot deleted the backport/backport-16365-to-2.x branch October 19, 2024 17:21
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachinpkale @dbwiddis