-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snapshot v2] Fix bug in snapshot update check for multiple v2 repo #16379
Conversation
Signed-off-by: Gaurav Bafna <[email protected]>
❌ Gradle check result for 9fdc504: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 9fdc504: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 9fdc504: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16379 +/- ##
============================================
- Coverage 72.07% 71.99% -0.09%
+ Complexity 64819 64803 -16
============================================
Files 5307 5307
Lines 302718 302722 +4
Branches 43734 43735 +1
============================================
- Hits 218178 217938 -240
- Misses 66638 66938 +300
+ Partials 17902 17846 -56 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit 9096aee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 9096aee) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ject#16379) Signed-off-by: Gaurav Bafna <[email protected]>
Description
When we update a repository-v2 , it fails with
This is because of bug in
repositoryWithShallowV2Exists
check which doesn't exclude itself while doing the check .Now we are excluding the repository-v2 which is getting updated .
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.