New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize remote store GC flow with pinned timestamps #15943

Merged

gbbafna merged 9 commits into opensearch-project:main from sachinpkale:gc-optimizations

Sep 25, 2024

Member

sachinpkale commented Sep 16, 2024 •

edited

Loading

Description

Added a bunch of optimisations in remote store garbage collection flow to work with pinned timestamps
- If index is deleted and a snapshot containing the index is getting deleted:
  - If this is the last snapshot containing the index, delete remote store data (segments + translog)
  - else pass pinning entity for the snapshot that is getting deleted. This is required to delete the data specific to snapshot even if pinned timestamp scheduler runs later.
- For remote translog, avoid calling list metadata files if minRemoteGenReferenced - indexSettings().getRemoteTranslogExtraKeep() <= maxDeletedGenerationOnRemote
- For remote translog, make sure to keep metadata and generation deletion in sync. With this, if metadata file is present, we can ensure that generations corresponding to it are not deleted.
- Added integ tests around these scenarios.

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Contributor

github-actions bot commented Sep 16, 2024

❌ Gradle check result for 609bd01: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale force-pushed the gc-optimizations branch from 609bd01 to 3186ffa Compare

September 16, 2024 12:34

sachinpkale added the skip-changelog label

Contributor

github-actions bot commented Sep 16, 2024

❌ Gradle check result for 3186ffa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale force-pushed the gc-optimizations branch from 3186ffa to f07d64d Compare

September 16, 2024 13:49

Contributor

github-actions bot commented Sep 16, 2024

❌ Gradle check result for f07d64d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

opensearch-ci-bot mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for RemoteFsTimestampAwareTranslogTests #15818

Open

sachinpkale force-pushed the gc-optimizations branch from f07d64d to c344045 Compare

September 17, 2024 06:56

Contributor

github-actions bot commented Sep 17, 2024

❌ Gradle check result for c344045: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale force-pushed the gc-optimizations branch from c344045 to eb12d3c Compare

September 17, 2024 08:56

Contributor

github-actions bot commented Sep 17, 2024

❌ Gradle check result for eb12d3c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale force-pushed the gc-optimizations branch from eb12d3c to 6a4dab7 Compare

September 17, 2024 10:28

Contributor

github-actions bot commented Sep 17, 2024

❌ Gradle check result for 6a4dab7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 17, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT #14294

Open

[AUTOCUT] Gradle Check Flaky Test Report for DedicatedClusterSnapshotRestoreIT #15806

Open

[AUTOCUT] Gradle Check Flaky Test Report for RecoveryFromGatewayIT #14304

Open

[AUTOCUT] Gradle Check Flaky Test Report for DeleteSnapshotV2IT #15835

Open

[AUTOCUT] Gradle Check Flaky Test Report for IndicesRequestCacheIT #14288

Open

sachinpkale force-pushed the gc-optimizations branch from 6a4dab7 to 5ed7af5 Compare

September 18, 2024 03:20

sachinpkale changed the title ~~Optimize GC flow with pinned timestamps~~ Optimize remote store GC flow with pinned timestamps

sachinpkale marked this pull request as ready for review

September 18, 2024 03:36

sachinpkale requested review from anasalkouz, andrross, ashking94, Bukhtawar, CEHENKLE, dblock, dbwiddis, gbbafna and jed326 as code owners

September 18, 2024 03:36

This was referenced Sep 24, 2024

[AUTOCUT] Gradle Check Flaky Test Report for UpgradeClusterClientYamlTestSuiteIT #16068

Open

[AUTOCUT] Gradle Check Flaky Test Report for ClusterStateIT #16069

Open

[AUTOCUT] Gradle Check Flaky Test Report for ExceptionIT #16070

Open

Contributor

github-actions bot commented Sep 25, 2024

❌ Gradle check result for a52d224: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale added 9 commits

September 25, 2024 11:32


          Optimize GC flow with pinned timestamps

33afac1

Signed-off-by: Sachin Kale <[email protected]>


          Fix flakiness of the test

33327f3

Signed-off-by: Sachin Kale <[email protected]>


          Add more UTs

51f64f9

Signed-off-by: Sachin Kale <[email protected]>


          Change the way we skip calling list metadata repeatedly

39fcf8b

Signed-off-by: Sachin Kale <[email protected]>


          Address PR comments

6f77e51

Signed-off-by: Sachin Kale <[email protected]>


          Fix tests

ca6af65

Signed-off-by: Sachin Kale <[email protected]>


          Address PR comments

4f83dac

Signed-off-by: Sachin Kale <[email protected]>


          Fix flaky test

8d3e255

Signed-off-by: Sachin Kale <[email protected]>


          Address PR comments and fix flaky tests

af7fcbf

Signed-off-by: Sachin Kale <[email protected]>

sachinpkale force-pushed the gc-optimizations branch from a52d224 to af7fcbf Compare

September 25, 2024 06:02

opensearch-ci-bot mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for SpecificClusterManagerNodesIT #15944

Open

Contributor

github-actions bot commented Sep 25, 2024

✅ Gradle check result for af7fcbf: SUCCESS

gbbafna approved these changes

View reviewed changes

gbbafna merged commit dc4dbce into opensearch-project:main

33 of 36 checks passed

gbbafna added the backport 2.x label

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          Optimize remote store GC flow with pinned timestamps (#15943)

7dd7c38

Signed-off-by: Sachin Kale <[email protected]>
(cherry picked from commit dc4dbce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.x] Optimize remote store GC flow with pinned timestamps #16077

Merged

opensearch-ci-bot mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for AzureBlobStoreRepositoryTests #14291

Open

ashking94 pushed a commit that referenced this pull request


          [Backport 2.x] Optimize remote store GC flow with pinned timestamps (#…

a1846cf

…16077)

* Optimize remote store GC flow with pinned timestamps (#15943)

Signed-off-by: Sachin Kale <[email protected]>
(cherry picked from commit dc4dbce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix breaking changes

Signed-off-by: Sachin Kale <[email protected]>

---------

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sachin Kale <[email protected]>

opensearch-ci-bot mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStorePinnedTimestampsGarbageCollectionIT #16088

Open

ruai0511 pushed a commit to ruai0511/OpenSearch that referenced this pull request


          Optimize remote store GC flow with pinned timestamps (opensearch-proj…

5e911f1

…ect#15943)

Signed-off-by: Sachin Kale <[email protected]>

prudhvigodithi mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT prudhvigodithi/opensearch-build#82

Open

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Optimize remote store GC flow with pinned timestamps (opensearch-proj…

7be1d40

…ect#15943)

Signed-off-by: Sachin Kale <[email protected]>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Optimize remote store GC flow with pinned timestamps (opensearch-proj…

69a2c22

…ect#15943)

Signed-off-by: Sachin Kale <[email protected]>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Optimize remote store GC flow with pinned timestamps (opensearch-proj…

cbb7f29

…ect#15943)

Signed-off-by: Sachin Kale <[email protected]>

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request


          Optimize remote store GC flow with pinned timestamps (opensearch-proj…

6354c0b

…ect#15943)

Signed-off-by: Sachin Kale <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

linuxpi linuxpi left review comments

gbbafna gbbafna approved these changes

anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

andrross Awaiting requested review from andrross andrross is a code owner

ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

dblock Awaiting requested review from dblock dblock is a code owner

dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

jed326 Awaiting requested review from jed326 jed326 is a code owner

kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

mch2 Awaiting requested review from mch2 mch2 is a code owner

msfroh Awaiting requested review from msfroh msfroh is a code owner

nknize Awaiting requested review from nknize nknize is a code owner

owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

reta Awaiting requested review from reta reta is a code owner

Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

sohami Awaiting requested review from sohami sohami is a code owner

VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

Labels

backport 2.x skip-changelog