[Remote State] Disable remote publication if remote state disabled #15219
Conversation
shiv0408
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for c240d50: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
shiv0408
force-pushed
the
remote-state-disable
branch
from
c240d50 to
f23b757
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15219 +/- ##
==========================================
Coverage 71.86% 71.87%
+ Complexity 63227 63168 -59
==========================================
Files 5213 5213
Lines 295780 295781 +1
Branches 42725 42726 +1
==========================================
+ Hits 212568 212598 +30
+ Misses 65842 65724 -118
- Partials 17370 17459 +89 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/cluster/coordination/CoordinationState.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/gateway/remote/RemoteStatePublicationIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivansh Arora <[email protected]>
shiv0408
force-pushed
the
remote-state-disable
branch
from
f23b757 to
9b47d5b
Compare
|
❌ Gradle check result for 9ab68d7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 9b47d5b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <[email protected]>
shiv0408
force-pushed
the
remote-state-disable
branch
from
9ab68d7 to
a6e78ed
Compare
|
❌ Gradle check result for a6e78ed: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for a6e78ed: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…15219) * Disable remote publication if remote state disabled Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 689cfca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…15219) (#15402) * Disable remote publication if remote state disabled (cherry picked from commit 689cfca) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pensearch-project#15219) * Disable remote publication if remote state disabled Signed-off-by: Shivansh Arora <[email protected]>
…pensearch-project#15219) * Disable remote publication if remote state disabled Signed-off-by: Shivansh Arora <[email protected]>
…pensearch-project#15219) * Disable remote publication if remote state disabled Signed-off-by: Shivansh Arora <[email protected]>
…pensearch-project#15219) * Disable remote publication if remote state disabled Signed-off-by: Shivansh Arora <[email protected]>
Description
Fall back to legacy Transport publication if Remote State is disabled. We were earlier trying to use remote publication when remote state was disabled, as the remote state was disabled RemoteClusterStateService instance is null and we were hitting null pointer.
Related Issues
Resolves #15182
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.