[DOCS] Remove useless code or comment from 'docs/build.gralde' #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Request for Admin to accept this test. |
setiah
approved these changes
Feb 26, 2021
6 tasks
soosinha
added a commit
to soosinha/OpenSearch
that referenced
this pull request
Sep 19, 2023
commit 62feea0 Author: Sachin Kale <[email protected]> Date: Wed Sep 6 09:23:56 2023 +0530 Fix SharedClusterSnapshotRestoreIT and RestoreSnapshotIT Signed-off-by: Sachin Kale <[email protected]> commit fdd357c Author: Sachin Kale <[email protected]> Date: Tue Sep 5 15:24:10 2023 +0530 Fix CorruptedFileIT and SearchPreferenceIT Signed-off-by: Sachin Kale <[email protected]> commit f0f631b Author: bansvaru <[email protected]> Date: Mon Sep 4 19:31:02 2023 +0530 fix CorruptedFileIT.testPrimaryCorruptionDuringReplicationDoesNotFailReplicaShard for remote store Signed-off-by: bansvaru <[email protected]> commit 55acae7 Author: bansvaru <[email protected]> Date: Mon Sep 4 18:37:45 2023 +0530 fix CorruptedFileIT.testCorruptFileAndRecover for remote store Signed-off-by: bansvaru <[email protected]> commit b3262a5 Author: Shourya Dutta Biswas <[email protected]> Date: Mon Sep 4 18:24:06 2023 +0530 Fixing tests Signed-off-by: Shourya Dutta Biswas <[email protected]> commit 054a5c1 Author: Sachin Kale <[email protected]> Date: Mon Sep 4 16:16:32 2023 +0530 Mute SingleNodeDiscoveryIT.testCannotJoinNodeWithSingleNodeDiscovery Signed-off-by: Sachin Kale <[email protected]> commit e36fa0e Author: Gaurav Bafna <[email protected]> Date: Mon Sep 4 15:57:42 2023 +0530 mark SimpleStats as awaits fix as it doesn't index docs commit 2cf9d13 Author: Sachin Kale <[email protected]> Date: Mon Sep 4 15:52:40 2023 +0530 Fix SearchableSnapshotIT.testFileCacheStats Signed-off-by: Sachin Kale <[email protected]> commit b2e5dc6 Author: Shourya Dutta Biswas <[email protected]> Date: Mon Sep 4 15:21:34 2023 +0530 Fixing tests Signed-off-by: Shourya Dutta Biswas <[email protected]> commit a0eb936 Author: Sachin Kale <[email protected]> Date: Mon Sep 4 14:56:30 2023 +0530 Fix BlobStoreIncrementalityIT, again Signed-off-by: Sachin Kale <[email protected]> commit a437510 Author: Gaurav Bafna <[email protected]> Date: Mon Sep 4 14:54:39 2023 +0530 removing primary search preference as relocation is happening here commit 6753be8 Author: Sachin Kale <[email protected]> Date: Mon Sep 4 14:25:34 2023 +0530 Fix SegmentReplicationIT Signed-off-by: Sachin Kale <[email protected]> commit 65bc7cd Author: Sachin Kale <[email protected]> Date: Mon Sep 4 12:22:10 2023 +0530 Fix FullRollingRestartIT Signed-off-by: Sachin Kale <[email protected]> commit 59d08b3 Author: Ashish Singh <[email protected]> Date: Mon Sep 4 12:18:51 2023 +0530 Awaits fix MultiClusterRepoAccessIT.testConcurrentDeleteFromOtherCluster Signed-off-by: Ashish Singh <[email protected]> commit bc4a134 Author: Gaurav Bafna <[email protected]> Date: Mon Sep 4 12:16:23 2023 +0530 comparing only max seq no on replicas with primary . Avoid comparing global and local ckp commit 4437109 Author: Ashish Singh <[email protected]> Date: Mon Sep 4 12:01:19 2023 +0530 Fix SuggestSearchIT.testSuggestWithManyCandidates() test Signed-off-by: Ashish Singh <[email protected]> commit 892d78a Author: Sachin Kale <[email protected]> Date: Mon Sep 4 11:49:06 2023 +0530 Fix BlobStoreIncrementalityIT Signed-off-by: Sachin Kale <[email protected]> commit 6c2d70a Author: Ashish Singh <[email protected]> Date: Mon Sep 4 11:36:31 2023 +0530 Fix QueryRescorerIT.testEquivalence() test Signed-off-by: Ashish Singh <[email protected]> commit 2a89345 Author: Sachin Kale <[email protected]> Date: Mon Sep 4 10:52:18 2023 +0530 Fix SegmentReplicationStatsIT Signed-off-by: Sachin Kale <[email protected]> commit 34e4191 Author: Sachin Kale <[email protected]> Date: Sun Sep 3 18:50:51 2023 +0530 Fix SearchTimeoutIT Signed-off-by: Sachin Kale <[email protected]> commit 07b1296 Author: Sachin Kale <[email protected]> Date: Sun Sep 3 18:05:25 2023 +0530 Fix BlobStoreIncrementalityIT Signed-off-by: Sachin Kale <[email protected]> commit 3ec0d9a Author: Sachin Kale <[email protected]> Date: Sun Sep 3 17:11:34 2023 +0530 Mute SegmentReplicationPressureIT and SegmentReplicationWithRemoteStorePressureIT Signed-off-by: Sachin Kale <[email protected]> commit f09d6ed Author: Ranjith Ramachandra <[email protected]> Date: Sun Sep 3 16:36:49 2023 +0530 test commit f7a8bdd Author: Gaurav Bafna <[email protected]> Date: Sun Sep 3 15:51:34 2023 +0530 Skipping TruncatedRecoveryIT as we sync segments once from remote store and download all data for this test case commit 49ce212 Author: Ranjith Ramachandra <[email protected]> Date: Sun Sep 3 14:55:41 2023 +0530 test commit 0ec5189 Author: Gaurav Bafna <[email protected]> Date: Sun Sep 3 14:02:21 2023 +0530 omitting seg rep cluster setting it commit c7df464 Author: Ranjith Ramachandra <[email protected]> Date: Sun Sep 3 13:20:48 2023 +0530 updates commit a5803ea Author: Sachin Kale <[email protected]> Date: Sun Sep 3 12:33:50 2023 +0530 Fix too many open files in PartitionedRoutingIT by reducing number of docs Signed-off-by: Sachin Kale <[email protected]> commit 2fc1ca4 Author: Ashish Singh <[email protected]> Date: Sun Sep 3 09:44:11 2023 +0530 AwaitsFix 1 shallow test in CloneSnapshotIT Signed-off-by: Ashish Singh <[email protected]> commit c086764 Author: Ashish Singh <[email protected]> Date: Sun Sep 3 09:42:36 2023 +0530 AwaitsFix 2 shallow tests in SnapshotStatusApisIT Signed-off-by: Ashish Singh <[email protected]> commit 6a7d078 Author: Ashish Singh <[email protected]> Date: Sun Sep 3 09:37:36 2023 +0530 AwaitsFix testReuseInFileBasedPeerRecovery in RecoveryFromGatewayIT Signed-off-by: Ashish Singh <[email protected]> commit 8ef7368 Author: Ranjith Ramachandra <[email protected]> Date: Sun Sep 3 00:42:19 2023 +0530 test commit 29f5de5 Author: Ranjith Ramachandra <[email protected]> Date: Sun Sep 3 00:12:07 2023 +0530 update commit eefca84 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 23:39:10 2023 +0530 test commit c148ffc Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 22:57:52 2023 +0530 test commit b2eeda9 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 22:18:27 2023 +0530 test commit 59a0120 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 22:16:40 2023 +0530 test commit 20df770 Author: Ashish Singh <[email protected]> Date: Sat Sep 2 21:29:44 2023 +0530 Fix ClusterShardLimitIT Signed-off-by: Ashish Singh <[email protected]> commit b1c0bce Author: Gaurav Bafna <[email protected]> Date: Sat Sep 2 21:22:15 2023 +0530 Removing static to fix BooleanTermsIT and DerivativeIT commit 136f9dc Author: Sachin Kale <[email protected]> Date: Sat Sep 2 21:24:09 2023 +0530 Fix DiskThresholdDeciderIT Signed-off-by: Sachin Kale <[email protected]> commit 5b7af05 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 21:24:06 2023 +0530 test commit 83224fa Merge: eb37566 3d780c8 Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 21:09:52 2023 +0530 Merge pull request opensearch-project#153 from Bukhtawar/remote-store-enabled-its Fixup for SegrepReplicationRelocationIT commit eb37566 Author: Sachin Kale <[email protected]> Date: Sat Sep 2 21:09:07 2023 +0530 Fix SegmentReplicationAllocationIT Signed-off-by: Sachin Kale <[email protected]> commit 3d780c8 Merge: 5dc0e3f 7e94f98 Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 21:09:04 2023 +0530 Merge branch 'remote-store-enabled-its' into remote-store-enabled-its commit 5dc0e3f Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 21:04:32 2023 +0530 Fixup for SegrepReplicationRelocationIT Signed-off-by: Bukhtawar Khan <[email protected]> commit 7e94f98 Author: Gaurav Bafna <[email protected]> Date: Sat Sep 2 20:47:25 2023 +0530 Adding isRemoteStoreEnabled and await fix relocation IT commit f17ddf1 Author: Ashish Singh <[email protected]> Date: Sat Sep 2 19:53:53 2023 +0530 Awaits fix testSimplePreference in SearchPreferenceIT Signed-off-by: Ashish Singh <[email protected]> commit daa07c4 Merge: eeecea6 393a7af Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 18:33:58 2023 +0530 Merge pull request opensearch-project#152 from Bukhtawar/remote-store-enabled-its Change action names to make tests work forcefully commit 393a7af Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 18:32:58 2023 +0530 Change action names to make tests work forcefully Signed-off-by: Bukhtawar Khan <[email protected]> commit eeecea6 Author: Ashish Singh <[email protected]> Date: Sat Sep 2 18:30:39 2023 +0530 Awaits fix testNodesOnlyRandom in SearchPreferenceIT Signed-off-by: Ashish Singh <[email protected]> commit 499c2cd Author: Ashish Singh <[email protected]> Date: Sat Sep 2 18:29:01 2023 +0530 Awaits fix testNoPreferenceRandom in SearchPreferenceIT Signed-off-by: Ashish Singh <[email protected]> commit e7bcc8c Author: Ashish Singh <[email protected]> Date: Sat Sep 2 18:26:09 2023 +0530 Awaits fix RemoteStoreForceMergeIT Signed-off-by: Ashish Singh <[email protected]> commit 299df96 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 18:21:23 2023 +0530 push commit 741afb8 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 18:00:13 2023 +0530 update commit 6ab5add Author: Ashish Singh <[email protected]> Date: Sat Sep 2 17:58:02 2023 +0530 Fix testZeroRemoteStoreStatsOnNonRemoteStoreIndex in IndexStatsIT Signed-off-by: Ashish Singh <[email protected]> commit d945660 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 17:56:41 2023 +0530 updates commit c9acbbb Author: Sachin Kale <[email protected]> Date: Sat Sep 2 17:35:55 2023 +0530 Fix MedianAbsoluteDeviationIT Signed-off-by: Sachin Kale <[email protected]> commit 3e84751 Author: Ashish Singh <[email protected]> Date: Sat Sep 2 16:37:28 2023 +0530 Fix all tests in RemoveCorruptedShardDataCommandIT - 10 iters passed Signed-off-by: Ashish Singh <[email protected]> commit f77c722 Author: Gaurav Bafna <[email protected]> Date: Sat Sep 2 16:29:36 2023 +0530 ignoring test failing in segrep as well commit d08aadb Author: Sachin Kale <[email protected]> Date: Sat Sep 2 16:05:29 2023 +0530 Mute SegmentReplicationSnapshotIT Signed-off-by: Sachin Kale <[email protected]> commit fd7451c Author: Sachin Kale <[email protected]> Date: Sat Sep 2 15:52:27 2023 +0530 Fix ShardIndexingPressureSettingsIT Signed-off-by: Sachin Kale <[email protected]> commit c513180 Author: Sachin Kale <[email protected]> Date: Sat Sep 2 15:36:24 2023 +0530 Fix IndexingPressureIT and RemoteIndexSnapshotStatusApiIT Signed-off-by: Sachin Kale <[email protected]> commit 27e1d96 Merge: 27015e4 09e9ffa Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 15:33:00 2023 +0530 Merge pull request opensearch-project#151 from Bukhtawar/remote-store-enabled-its Empty replication leases on replica commit 09e9ffa Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 15:31:54 2023 +0530 Empty replication leases on replica Signed-off-by: Bukhtawar Khan <[email protected]> commit 27015e4 Author: Ashish Singh <[email protected]> Date: Sat Sep 2 15:21:46 2023 +0530 Fix AdjacencyMatrixIT - no failures in 10 iters Signed-off-by: Ashish Singh <[email protected]> commit f64c4fa Author: Sachin Kale <[email protected]> Date: Sat Sep 2 15:20:44 2023 +0530 Fix FiltersIT Signed-off-by: Sachin Kale <[email protected]> commit 9bea58d Author: Sachin Kale <[email protected]> Date: Sat Sep 2 14:41:48 2023 +0530 Fix ConcurrentSearchTasksIT Signed-off-by: Sachin Kale <[email protected]> commit 907ca18 Author: Sachin Kale <[email protected]> Date: Sat Sep 2 14:21:19 2023 +0530 Fix AbstractTasksIT Signed-off-by: Sachin Kale <[email protected]> commit 268e711 Merge: e805cec 11fd9d9 Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 13:31:10 2023 +0530 Merge pull request opensearch-project#150 from Bukhtawar/remote-store-enabled-its Disabling tests as write thread pool block on replica doesn't impact … commit 11fd9d9 Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 13:30:25 2023 +0530 Disabling tests as write thread pool block on replica doesn't impact primary term validation on transport worker Signed-off-by: Bukhtawar Khan <[email protected]> commit e805cec Author: Gaurav Bafna <[email protected]> Date: Sat Sep 2 12:47:12 2023 +0530 ignoring WRR and IndexRecoveryIT Signed-off-by: Gaurav Bafna <[email protected]> commit e971bc1 Author: Gaurav Bafna <[email protected]> Date: Sat Sep 2 12:39:08 2023 +0530 ignoring tests which should fail with remote store commit c5150b0 Merge: 09e08e3 6f60931 Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 11:55:37 2023 +0530 Merge pull request opensearch-project#149 from Bukhtawar/remote-store-enabled-its Fix up searchable snapshot to not sync from remote commit 6f60931 Author: Bukhtawar Khan <[email protected]> Date: Sat Sep 2 11:52:38 2023 +0530 Fix searchable snapshot to not sync from remote Signed-off-by: Bukhtawar Khan <[email protected]> commit 09e08e3 Author: Sachin Kale <[email protected]> Date: Sat Sep 2 11:25:38 2023 +0530 Fix MedianAbsoluteDeviationIT Signed-off-by: Sachin Kale <[email protected]> commit ec30cb6 Author: Gaurav Bafna <[email protected]> Date: Sat Sep 2 11:23:12 2023 +0530 Setting primary preference in Rest Request and clients commit b2e2c86 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 11:10:26 2023 +0530 update commit 2f85d03 Author: Gaurav Bafna <[email protected]> Date: Sat Sep 2 10:57:55 2023 +0530 using setUpTest instead of setupSuiteScopeCluster commit 0af7d70 Author: Ranjith Ramachandra <[email protected]> Date: Sat Sep 2 10:06:24 2023 +0530 update commit f8cf4c4 Author: Sachin Kale <[email protected]> Date: Sat Sep 2 00:52:12 2023 +0530 Fix RepositoriesIT Signed-off-by: Sachin Kale <[email protected]> commit 9fdcb39 Author: Sachin Kale <[email protected]> Date: Fri Sep 1 23:07:08 2023 +0530 Fix bunch of tests that were still using SuiteScopeTestCase Signed-off-by: Sachin Kale <[email protected]> commit 0f29caf Merge: 998cc58 4bdc7c1 Author: Arpit Bandejiya <[email protected]> Date: Fri Sep 1 18:06:20 2023 +0530 Merge branch 'remote-store-enabled-its' of github.com:sachinpkale/OpenSearch into remote-store-enabled-its commit 998cc58 Author: Arpit Bandejiya <[email protected]> Date: Fri Sep 1 18:05:55 2023 +0530 Fix the GlobalCheckpointSyncIT commit 4bdc7c1 Author: Sachin Kale <[email protected]> Date: Fri Sep 1 17:34:04 2023 +0530 Enforce test scope for all the test with SuiteScopeTestCase Signed-off-by: Sachin Kale <[email protected]> commit 10dc127 Author: Ranjith Ramachandra <[email protected]> Date: Fri Sep 1 16:58:28 2023 +0530 updated commit 6144fc8 Author: Gaurav Bafna <[email protected]> Date: Fri Sep 1 17:18:32 2023 +0530 Fixing cluster state commit 215b936 Author: Shourya Dutta Biswas <[email protected]> Date: Fri Sep 1 17:07:15 2023 +0530 Adding assertBusy to SearchSliceIT Signed-off-by: Shourya Dutta Biswas <[email protected]> commit 6c28a4e Author: Shourya Dutta Biswas <[email protected]> Date: Fri Sep 1 16:24:32 2023 +0530 Muting tests not applicable to remote store Signed-off-by: Shourya Dutta Biswas <[email protected]> commit 3be1f3d Author: Sachin Kale <[email protected]> Date: Fri Sep 1 14:59:44 2023 +0530 Do not wipe cluster at all Signed-off-by: Sachin Kale <[email protected]> commit 12775c3 Author: Sachin Kale <[email protected]> Date: Fri Sep 1 14:48:42 2023 +0530 Few fixes Signed-off-by: Sachin Kale <[email protected]> commit 98322fa Author: Dharmesh 💤 <[email protected]> Date: Fri Sep 1 02:59:54 2023 +0530 Removing unnecessary diffs Signed-off-by: Dharmesh 💤 <[email protected]> commit 3262e78 Author: Dharmesh 💤 <[email protected]> Date: Fri Sep 1 00:30:35 2023 +0530 Removing remote store specific cluster settings instead rely on node attributes, fixed UTs and ITs Signed-off-by: Dharmesh 💤 <[email protected]> commit d0af9e3 Author: Ashish Singh <[email protected]> Date: Fri Sep 1 13:16:55 2023 +0530 Remove repository wipe Signed-off-by: Ashish Singh <[email protected]> commit dddf695 Author: Sachin Kale <[email protected]> Date: Fri Sep 1 11:32:14 2023 +0530 Fix AbstractMultiClustersTestCase Signed-off-by: Sachin Kale <[email protected]> commit 7f06e8e Author: Sachin Kale <[email protected]> Date: Fri Sep 1 11:18:50 2023 +0530 Make all tests run in TEST scope Signed-off-by: Sachin Kale <[email protected]> commit 55bd2ac Author: Sachin Kale <[email protected]> Date: Fri Sep 1 09:29:20 2023 +0530 Change default scope to TEST Signed-off-by: Sachin Kale <[email protected]> commit b7534f5 Author: Sachin Kale <[email protected]> Date: Thu Aug 31 21:04:21 2023 +0530 Fixing bunch of tests Signed-off-by: Sachin Kale <[email protected]> commit 3b93358 Author: Sachin Kale <[email protected]> Date: Thu Aug 31 11:03:10 2023 +0530 Enable remote store for all integ tests Signed-off-by: Sachin Kale <[email protected]> commit 228cf7b Author: Marc Handalian <[email protected]> Date: Tue Aug 29 22:55:14 2023 -0700 Mock implementation. Signed-off-by: Marc Handalian <[email protected]> commit 6919141 Author: Dharmesh 💤 <[email protected]> Date: Wed Aug 30 20:32:10 2023 +0530 Fixing Additional Tests, there might still be some flaky ones Signed-off-by: Dharmesh 💤 <[email protected]> commit d0c2b5b Author: Dharmesh 💤 <[email protected]> Date: Wed Aug 30 14:33:36 2023 +0530 Removing verifyLocally and move to existing verify methods. If the repository is a system repository only local verification will happen Signed-off-by: Dharmesh 💤 <[email protected]> commit c94713e Author: Dharmesh 💤 <[email protected]> Date: Tue Aug 29 23:56:52 2023 +0530 Fixing ITs Signed-off-by: Dharmesh 💤 <[email protected]> commit a227d20 Author: Dharmesh 💤 <[email protected]> Date: Tue Aug 29 17:02:58 2023 +0530 Updating/Fixing tests Signed-off-by: Dharmesh 💤 <[email protected]> commit bc0e562 Author: Dharmesh 💤 <[email protected]> Date: Mon Aug 28 19:42:26 2023 +0530 Introducing verifylocally to perform verification without cluster being formed such that a node is able to connect to connect and has necessary permissions Signed-off-by: Dharmesh 💤 <[email protected]> commit 23cc00f Author: Dharmesh 💤 <[email protected]> Date: Mon Aug 28 14:33:41 2023 +0530 Addressed few comments, updated javadocs and added verify logic to be updated once system repo pr is merged Signed-off-by: Dharmesh 💤 <[email protected]> commit 40f85c7 Author: Dharmesh 💤 <[email protected]> Date: Sun Aug 27 18:10:22 2023 +0530 Updating REMOTE_STORE_COMPATIBILITY_MODE_SETTING value enum javadoc Signed-off-by: Dharmesh 💤 <[email protected]> commit d07c6f6 Author: Dharmesh 💤 <[email protected]> Date: Sun Aug 27 17:11:34 2023 +0530 Updating CompatibilityMode enum Signed-off-by: Dharmesh 💤 <[email protected]> commit 496c00d Author: Dharmesh 💤 <[email protected]> Date: Sun Aug 27 16:55:56 2023 +0530 Fixing tests Signed-off-by: Dharmesh 💤 <[email protected]> commit 2956dd1 Author: Dharmesh 💤 <[email protected]> Date: Sun Aug 27 13:04:09 2023 +0530 Using CoundDownLatch Signed-off-by: Dharmesh 💤 <[email protected]> commit d97cc06 Author: Dharmesh 💤 <[email protected]> Date: Sun Aug 27 02:53:24 2023 +0530 Updating javadoc and RepoRegistration IT Signed-off-by: Dharmesh 💤 <[email protected]> commit a7316a8 Author: Dharmesh 💤 <[email protected]> Date: Sun Aug 27 02:29:08 2023 +0530 Fixing repository verification logic Signed-off-by: Dharmesh 💤 <[email protected]> commit f1409b1 Author: Dharmesh 💤 <[email protected]> Date: Sat Aug 26 22:10:39 2023 +0530 Code changes to do the repository verification at the time of node bootstrap. Signed-off-by: Dharmesh 💤 <[email protected]> commit d6c7866 Author: Dharmesh 💤 <[email protected]> Date: Sat Aug 26 14:20:01 2023 +0530 [Remote Store] Changes to perform repository registration during bootstrap via node attributes. Signed-off-by: Dharmesh 💤 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#142
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.