-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more identifiers to gradle-check job webhook payload #13714
Conversation
Signed-off-by: Rishabh Singh <[email protected]>
@dblock Do you ming taking a look at it again? |
❌ Gradle check result for 7c79941: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 7c79941: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13714 +/- ##
============================================
+ Coverage 71.42% 71.55% +0.13%
- Complexity 59978 61232 +1254
============================================
Files 4985 5060 +75
Lines 282275 287854 +5579
Branches 40946 41689 +743
============================================
+ Hits 201603 205973 +4370
- Misses 63999 64868 +869
- Partials 16673 17013 +340 ☔ View full report in Codecov by Sentry. |
(cherry picked from commit 4700be3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.1
# Create a new branch
git switch --create backport/backport-13714-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4700be3e72e9193d438718120d1228222785786c
# Push it to GitHub
git push --set-upstream origin backport/backport-13714-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.1 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.2
# Create a new branch
git switch --create backport/backport-13714-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4700be3e72e9193d438718120d1228222785786c
# Push it to GitHub
git push --set-upstream origin backport/backport-13714-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.2 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.3 2.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.3
# Create a new branch
git switch --create backport/backport-13714-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4700be3e72e9193d438718120d1228222785786c
# Push it to GitHub
git push --set-upstream origin backport/backport-13714-to-2.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.3 Then, create a pull request where the |
@rishabh6788 It looks like this had a number of backports targets labeled, IMO the only backport that should be applied is to 2.x which I have just merged. This still track for you? |
This comment was marked as resolved.
This comment was marked as resolved.
Agree with only 2.x back-port label. Not sure why the bot applied those labels. |
Description
Fixes the revert in #13027.
Solution proposed in #13025 (comment)
From my test run I can confirm that pr description now does not contains new lines, the new line character is now escaped.
Sample run and output https://github.com/rishabh6788/OpenSearch/actions/runs/9117260498/job/25067702370.
Related Issues
gradle check
job for runs against committed code opensearch-build#4469Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedAPI changes companion pull request created.Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.