Skip to content

[Backport 2.x] Fetch all the locks for a shard to avoid multiple remote store calls#12037

Merged
andrross merged 1 commit into2.xfrom
backport/backport-11987-to-2.x
Jan 26, 2024
Merged

[Backport 2.x] Fetch all the locks for a shard to avoid multiple remote store calls#12037
andrross merged 1 commit into2.xfrom
backport/backport-11987-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 6e744f5 from #11987.

…11987)

* Fetch all the locks for a shard to avoid multiple calls

Signed-off-by: Sachin Kale <kalsac@amazon.com>

* Fix lock file comparison issue

Signed-off-by: Sachin Kale <kalsac@amazon.com>

* Add unit tests

Signed-off-by: Sachin Kale <kalsac@amazon.com>

* Add more unit tests

Signed-off-by: Sachin Kale <kalsac@amazon.com>

* Address PR comments

Signed-off-by: Sachin Kale <kalsac@amazon.com>

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit 6e744f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 02cd2bb

Incompatible components

Incompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

@github-actions
Copy link
Contributor

✅ Gradle check result for 02cd2bb: SUCCESS

@codecov
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fd1493a) 71.01% compared to head (02cd2bb) 71.01%.

Files Patch % Lines
...earch/index/store/RemoteSegmentStoreDirectory.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                2.x   #12037   +/-   ##
=========================================
  Coverage     71.01%   71.01%           
+ Complexity    59349    59313   -36     
=========================================
  Files          4891     4891           
  Lines        279970   279974    +4     
  Branches      41070    41070           
=========================================
+ Hits         198811   198832   +21     
+ Misses        64280    64261   -19     
- Partials      16879    16881    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit 6d938b8 into 2.x Jan 26, 2024
@github-actions github-actions bot deleted the backport/backport-11987-to-2.x branch January 26, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant